* Re: [LKP] [selftests/vm] a05ef00c97: kernel_selftests.vm.vmalloc_stability_smoke_test.fail
[not found] <20190311074315.GD10839@shao2-debian>
@ 2019-03-11 17:20 ` Linus Torvalds
2019-03-11 21:56 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Linus Torvalds @ 2019-03-11 17:20 UTC (permalink / raw)
To: kernel test robot
Cc: Uladzislau Rezki, Shuah Khan, Kees Cook, Matthew Wilcox,
Michal Hocko, Oleksiy Avramchenko, Thomas Gleixner,
Andrew Morton, LKML, lkp
On Mon, Mar 11, 2019 at 12:43 AM kernel test robot
<rong.a.chen@intel.com> wrote:
>
> ./run_vmtests: line 217: ./test_vmalloc.sh: Permission denied
I marked that script executable:
6bc3fe8e7e17 ("tools: mark 'test_vmalloc.sh' executable")
although perhaps the better fix would have been to explicitly use the
shell to start it in the 'run_vmtests' script instead?
We have a lot of files that aren't marked executable, probably because
they came in as (or were generated as) non-git patches. Often through
Andrew's workflow.
But most of them don't seem to matter, because they get run using
explicit script engines. So I only fixed up this one case.
Linus
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [LKP] [selftests/vm] a05ef00c97: kernel_selftests.vm.vmalloc_stability_smoke_test.fail
2019-03-11 17:20 ` [LKP] [selftests/vm] a05ef00c97: kernel_selftests.vm.vmalloc_stability_smoke_test.fail Linus Torvalds
@ 2019-03-11 21:56 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2019-03-11 21:56 UTC (permalink / raw)
To: Linus Torvalds
Cc: kernel test robot, Uladzislau Rezki, Shuah Khan, Kees Cook,
Matthew Wilcox, Michal Hocko, Oleksiy Avramchenko,
Thomas Gleixner, LKML, lkp
On Mon, 11 Mar 2019 10:20:06 -0700 Linus Torvalds <torvalds@linux-foundation.org> wrote:
> On Mon, Mar 11, 2019 at 12:43 AM kernel test robot
> <rong.a.chen@intel.com> wrote:
> >
> > ./run_vmtests: line 217: ./test_vmalloc.sh: Permission denied
>
> I marked that script executable:
>
> 6bc3fe8e7e17 ("tools: mark 'test_vmalloc.sh' executable")
>
> although perhaps the better fix would have been to explicitly use the
> shell to start it in the 'run_vmtests' script instead?
>
> We have a lot of files that aren't marked executable, probably because
> they came in as (or were generated as) non-git patches. Often through
> Andrew's workflow.
Not only that. patch(1) doesn't set the x bit. So if someone
downloads and applies patch-5.0-rc1.xz (as we say to do in the
documentation), their kernel won't work correctly.
This happens fairly regularly and the fix is to replace
test_vmalloc.sh ...
with
/bin/sh test_vmalloc.sh ...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-11 21:56 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20190311074315.GD10839@shao2-debian>
2019-03-11 17:20 ` [LKP] [selftests/vm] a05ef00c97: kernel_selftests.vm.vmalloc_stability_smoke_test.fail Linus Torvalds
2019-03-11 21:56 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®