From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Su Yanjun <suyj.fnst@cn.fujitsu.com>, <davem@davemloft.net>,
<kuznet@ms2.inr.ac.ru>, <yoshfuji@linux-ipv6.org>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH] xfrm6_tunnel: Fix potential panic when unloading xfrm6_tunnel module
Date: Sun, 17 Mar 2019 11:13:39 +0100 [thread overview]
Message-ID: <20190317101338.GQ6035@gauss3.secunet.de> (raw)
In-Reply-To: <20190315062438.id3664ccow5uxgvt@gondor.apana.org.au>
On Fri, Mar 15, 2019 at 02:24:38PM +0800, Herbert Xu wrote:
> On Thu, Mar 14, 2019 at 02:59:42PM +0800, Su Yanjun wrote:
> > When unloading xfrm6_tunnel module, xfrm6_tunnel_fini directly
> > frees the xfrm6_tunnel_spi_kmem. Maybe someone has gotten the
> > xfrm6_tunnel_spi, so need to wait it.
> >
> > Fixes: 91cc3bb0b04ff("xfrm6_tunnel: RCU conversion")
> > Signed-off-by: Su Yanjun <suyj.fnst@cn.fujitsu.com>
> > ---
> > net/ipv6/xfrm6_tunnel.c | 4 ++++
> > 1 file changed, 4 insertions(+)
>
> This looks good to me. And it's not just the matter of accessing
> freed memory. A worse problem would be trying to execute code
> from an unloaded module.
>
> Acked-by: Herbert Xu <herbert@gondor.apana.org.au>
Applied, thanks everyone!
prev parent reply other threads:[~2019-03-17 10:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-14 6:59 Su Yanjun
2019-03-15 6:24 ` Herbert Xu
2019-03-17 10:13 ` Steffen Klassert [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190317101338.GQ6035@gauss3.secunet.de \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=suyj.fnst@cn.fujitsu.com \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®