mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Nick Desaulniers <ndesaulniers@google.com>
Cc: Matthias Kaehlcke <mka@chromium.org>,
	Andy Lutomirski <luto@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
	"H . Peter Anvin" <hpa@zytor.com>,
	x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Manoj Gupta <manojgupta@chromium.org>,
	Tiancong Wang <tcwang@chromium.org>,
	Stephen Hines <srhines@google.com>,
	clang-built-linux@googlegroups.com,
	Masahiro Yamada <yamada.masahiro@socionext.com>
Subject: Re: [PATCH] x86/vdso: include generic __lshrdi3 in 32-bit vDSO
Date: Mon, 18 Mar 2019 18:16:04 +0100	[thread overview]
Message-ID: <20190318171604.GU6058@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <CAKwvOdkXobdu74Fo0fiS4xkikqZdKS=gWN61pVAFBbXRPoenRw@mail.gmail.com>

On Mon, Mar 18, 2019 at 10:09:37AM -0700, Nick Desaulniers wrote:
> On Fri, Mar 15, 2019 at 3:29 PM Matthias Kaehlcke <mka@chromium.org> wrote:
> > On Fri, Mar 15, 2019 at 02:31:09PM -0700, 'Nick Desaulniers' via Clang Built Linux wrote:
> > > Is there a config I can set to reproduce this, in order to help
> > > test?
> >
> > I encountered it with a Chrome OS specific configuration, but a
> > defconfig should do.
> 
> defconfig selects CONFIG_OPTIMIZE_FOR_PERFORMANCE=y.  I needed to
> select CONFIG_CC_OPTIMIZE_FOR_SIZE=y to repro.  My CI is simply
> running defconfigs, which is why I didn't catch this.

I suspect the right fix is to make clang use -Os and abolish that -Oz
madness.

  reply	other threads:[~2019-03-18 17:16 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-15 19:54 Matthias Kaehlcke
2019-03-15 21:31 ` Nick Desaulniers
2019-03-15 22:29   ` Matthias Kaehlcke
2019-03-15 23:18     ` hpa
2019-03-18  8:59       ` Peter Zijlstra
2019-03-18 17:09     ` Nick Desaulniers
2019-03-18 17:16       ` Peter Zijlstra [this message]
2019-03-18 20:44         ` Matthias Kaehlcke
2019-03-18 23:03           ` Peter Zijlstra
2019-03-20 14:06   ` Masahiro Yamada
2019-03-20 13:55 ` Masahiro Yamada
2019-03-20 15:45   ` Matthias Kaehlcke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190318171604.GU6058@hirez.programming.kicks-ass.net \
    --to=peterz@infradead.org \
    --cc=bp@alien8.de \
    --cc=clang-built-linux@googlegroups.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=luto@kernel.org \
    --cc=manojgupta@chromium.org \
    --cc=mingo@redhat.com \
    --cc=mka@chromium.org \
    --cc=ndesaulniers@google.com \
    --cc=srhines@google.com \
    --cc=tcwang@chromium.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    --cc=yamada.masahiro@socionext.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome