* [PATCH net-next 1/3] net: phy: mdio-bcm-unimac: Remove print of base address
[not found] <20190320164517.29608-1-f.fainelli@gmail.com>
@ 2019-03-20 16:45 ` Florian Fainelli
2019-03-20 16:45 ` [PATCH net-next 2/3] net: dsa: bcm_sf2: " Florian Fainelli
2019-03-20 16:45 ` [PATCH net-next 3/3] net: systemport: " Florian Fainelli
2 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-03-20 16:45 UTC (permalink / raw)
To: netdev; +Cc: davem, Florian Fainelli, Andrew Lunn, Heiner Kallweit, open list
Since commit ad67b74d2469 ("printk: hash addresses printed with %p")
pointers are being hashed when printed. Displaying the virtual memory at
bootup time is not helpful, especially given we use a dev_info() which
already displays the platform device's address.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/phy/mdio-bcm-unimac.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/phy/mdio-bcm-unimac.c b/drivers/net/phy/mdio-bcm-unimac.c
index 8295bc7c8c20..3a592629dc7e 100644
--- a/drivers/net/phy/mdio-bcm-unimac.c
+++ b/drivers/net/phy/mdio-bcm-unimac.c
@@ -292,7 +292,7 @@ static int unimac_mdio_probe(struct platform_device *pdev)
platform_set_drvdata(pdev, priv);
- dev_info(&pdev->dev, "Broadcom UniMAC MDIO bus at 0x%p\n", priv->base);
+ dev_info(&pdev->dev, "Broadcom UniMAC MDIO bus\n");
return 0;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH net-next 2/3] net: dsa: bcm_sf2: Remove print of base address
[not found] <20190320164517.29608-1-f.fainelli@gmail.com>
2019-03-20 16:45 ` [PATCH net-next 1/3] net: phy: mdio-bcm-unimac: Remove print of base address Florian Fainelli
@ 2019-03-20 16:45 ` Florian Fainelli
2019-03-20 16:45 ` [PATCH net-next 3/3] net: systemport: " Florian Fainelli
2 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-03-20 16:45 UTC (permalink / raw)
To: netdev; +Cc: davem, Florian Fainelli, Andrew Lunn, Vivien Didelot, open list
Since commit ad67b74d2469 ("printk: hash addresses printed with %p")
pointers are being hashed when printed. Displaying the virtual memory at
bootup time is not helpful, we use a dev_info() print which already
displays the platform device's address.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/dsa/bcm_sf2.c | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/drivers/net/dsa/bcm_sf2.c b/drivers/net/dsa/bcm_sf2.c
index c8e3f05e1d72..4ccb3239f5f7 100644
--- a/drivers/net/dsa/bcm_sf2.c
+++ b/drivers/net/dsa/bcm_sf2.c
@@ -1188,10 +1188,11 @@ static int bcm_sf2_sw_probe(struct platform_device *pdev)
if (ret)
goto out_mdio;
- pr_info("Starfighter 2 top: %x.%02x, core: %x.%02x base: 0x%p, IRQs: %d, %d\n",
- priv->hw_params.top_rev >> 8, priv->hw_params.top_rev & 0xff,
- priv->hw_params.core_rev >> 8, priv->hw_params.core_rev & 0xff,
- priv->core, priv->irq0, priv->irq1);
+ dev_info(&pdev->dev,
+ "Starfighter 2 top: %x.%02x, core: %x.%02x, IRQs: %d, %d\n",
+ priv->hw_params.top_rev >> 8, priv->hw_params.top_rev & 0xff,
+ priv->hw_params.core_rev >> 8, priv->hw_params.core_rev & 0xff,
+ priv->irq0, priv->irq1);
return 0;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* [PATCH net-next 3/3] net: systemport: Remove print of base address
[not found] <20190320164517.29608-1-f.fainelli@gmail.com>
2019-03-20 16:45 ` [PATCH net-next 1/3] net: phy: mdio-bcm-unimac: Remove print of base address Florian Fainelli
2019-03-20 16:45 ` [PATCH net-next 2/3] net: dsa: bcm_sf2: " Florian Fainelli
@ 2019-03-20 16:45 ` Florian Fainelli
2 siblings, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2019-03-20 16:45 UTC (permalink / raw)
To: netdev
Cc: davem, Florian Fainelli,
open list:BROADCOM SYSTEMPORT ETHERNET DRIVER, open list
Since commit ad67b74d2469 ("printk: hash addresses printed with %p")
pointers are being hashed when printed. Displaying the virtual memory at
bootup time is not helpful, especially given we use a dev_info() which
already displays the platform device's address.
Signed-off-by: Florian Fainelli <f.fainelli@gmail.com>
---
drivers/net/ethernet/broadcom/bcmsysport.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/broadcom/bcmsysport.c b/drivers/net/ethernet/broadcom/bcmsysport.c
index bc3ac369cbe3..c86515f7fd2f 100644
--- a/drivers/net/ethernet/broadcom/bcmsysport.c
+++ b/drivers/net/ethernet/broadcom/bcmsysport.c
@@ -2599,11 +2599,11 @@ static int bcm_sysport_probe(struct platform_device *pdev)
priv->rev = topctrl_readl(priv, REV_CNTL) & REV_MASK;
dev_info(&pdev->dev,
- "Broadcom SYSTEMPORT%s" REV_FMT
- " at 0x%p (irqs: %d, %d, TXQs: %d, RXQs: %d)\n",
+ "Broadcom SYSTEMPORT%s " REV_FMT
+ " (irqs: %d, %d, TXQs: %d, RXQs: %d)\n",
priv->is_lite ? " Lite" : "",
(priv->rev >> 8) & 0xff, priv->rev & 0xff,
- priv->base, priv->irq0, priv->irq1, txq, rxq);
+ priv->irq0, priv->irq1, txq, rxq);
return 0;
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread