* [PATCH] thunderbolt: Fix to check the return value of kmemdup
@ 2019-03-19 18:38 Aditya Pakki
2019-03-21 6:00 ` Mika Westerberg
0 siblings, 1 reply; 2+ messages in thread
From: Aditya Pakki @ 2019-03-19 18:38 UTC (permalink / raw)
To: pakki001
Cc: kjlu, Andreas Noever, Michael Jamet, Mika Westerberg,
Yehezkel Bernat, linux-kernel
uuid in add_switch is allocted via kmemdup which can fail. The patch
logs the error in such a scenario.
Signed-off-by: Aditya Pakki <pakki001@umn.edu>
---
drivers/thunderbolt/icm.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
index e3fc920af682..8df8057cd79e 100644
--- a/drivers/thunderbolt/icm.c
+++ b/drivers/thunderbolt/icm.c
@@ -473,6 +473,7 @@ static void add_switch(struct tb_switch *parent_sw, u64 route,
goto out;
sw->uuid = kmemdup(uuid, sizeof(*uuid), GFP_KERNEL);
+ WARN_ONCE(!sw->uuid, "%s: sw->uuid = NULL", __func__);
sw->connection_id = connection_id;
sw->connection_key = connection_key;
sw->link = link;
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] thunderbolt: Fix to check the return value of kmemdup
2019-03-19 18:38 [PATCH] thunderbolt: Fix to check the return value of kmemdup Aditya Pakki
@ 2019-03-21 6:00 ` Mika Westerberg
0 siblings, 0 replies; 2+ messages in thread
From: Mika Westerberg @ 2019-03-21 6:00 UTC (permalink / raw)
To: Aditya Pakki
Cc: kjlu, Andreas Noever, Michael Jamet, Yehezkel Bernat, linux-kernel
On Tue, Mar 19, 2019 at 01:38:34PM -0500, Aditya Pakki wrote:
> uuid in add_switch is allocted via kmemdup which can fail. The patch
> logs the error in such a scenario.
>
> Signed-off-by: Aditya Pakki <pakki001@umn.edu>
> ---
> drivers/thunderbolt/icm.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/thunderbolt/icm.c b/drivers/thunderbolt/icm.c
> index e3fc920af682..8df8057cd79e 100644
> --- a/drivers/thunderbolt/icm.c
> +++ b/drivers/thunderbolt/icm.c
> @@ -473,6 +473,7 @@ static void add_switch(struct tb_switch *parent_sw, u64 route,
> goto out;
>
> sw->uuid = kmemdup(uuid, sizeof(*uuid), GFP_KERNEL);
> + WARN_ONCE(!sw->uuid, "%s: sw->uuid = NULL", __func__);
I don't think it is good idea to continue here since uuid is kind of
needed. Maybe do the same as above (goto out) with a useful error
message along the lines of "cannot allocate memory for switch" or so.
Remember to use tb_switch_put() in that case.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-21 6:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-19 18:38 [PATCH] thunderbolt: Fix to check the return value of kmemdup Aditya Pakki
2019-03-21 6:00 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®