From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Yue Haibing <yuehaibing@huawei.com>
Cc: jespern@axis.com, larper@axis.com, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@axis.com
Subject: Re: [PATCH -next] pinctrl: artpec6: Make two functions static
Date: Thu, 21 Mar 2019 16:59:23 +0100 [thread overview]
Message-ID: <20190321155923.z4jbelggbqp2vjio@axis.com> (raw)
In-Reply-To: <20190321150909.3576-1-yuehaibing@huawei.com>
On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote:
> From: YueHaibing <yuehaibing@huawei.com>
>
> Fix sparse warnings:
>
> drivers/pinctrl/pinctrl-artpec6.c:691:5: warning:
> symbol 'artpec6_pmx_enable' was not declared. Should it be static?
> drivers/pinctrl/pinctrl-artpec6.c:705:6: warning:
> symbol 'artpec6_pmx_disable' was not declared. Should it be static?
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
Acked-by: Jesper Nilsson <jesper.nilsson@axis.com>
> ---
> drivers/pinctrl/pinctrl-artpec6.c | 10 ++++++----
> 1 file changed, 6 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pinctrl/pinctrl-artpec6.c b/drivers/pinctrl/pinctrl-artpec6.c
> index d89dc43..e836850 100644
> --- a/drivers/pinctrl/pinctrl-artpec6.c
> +++ b/drivers/pinctrl/pinctrl-artpec6.c
> @@ -688,8 +688,9 @@ static void artpec6_pmx_select_func(struct pinctrl_dev *pctldev,
> }
> }
>
> -int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
> - unsigned int group)
> +static int artpec6_pmx_enable(struct pinctrl_dev *pctldev,
> + unsigned int function,
> + unsigned int group)
> {
> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>
> @@ -702,8 +703,9 @@ int artpec6_pmx_enable(struct pinctrl_dev *pctldev, unsigned int function,
> return 0;
> }
>
> -void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
> - unsigned int group)
> +static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
> + unsigned int function,
> + unsigned int group)
> {
> struct artpec6_pmx *pmx = pinctrl_dev_get_drvdata(pctldev);
>
> --
> 2.7.0
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
next prev parent reply other threads:[~2019-03-21 15:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 15:09 Yue Haibing
2019-03-21 15:59 ` Jesper Nilsson [this message]
2019-04-04 15:26 ` Linus Walleij
2019-04-08 18:01 ` Nathan Chancellor
2019-04-09 1:35 ` YueHaibing
2019-04-09 6:56 ` Jesper Nilsson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190321155923.z4jbelggbqp2vjio@axis.com \
--to=jesper.nilsson@axis.com \
--cc=jespern@axis.com \
--cc=larper@axis.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@axis.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®