From: Jesper Nilsson <jesper.nilsson@axis.com>
To: Nathan Chancellor <natechancellor@gmail.com>
Cc: Yue Haibing <yuehaibing@huawei.com>,
jespern@axis.com, larper@axis.com, linus.walleij@linaro.org,
linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org,
linux-arm-kernel@axis.com
Subject: Re: [PATCH -next] pinctrl: artpec6: Make two functions static
Date: Tue, 9 Apr 2019 08:56:21 +0200 [thread overview]
Message-ID: <20190409065621.2yfx5nqzpuxyj46p@axis.com> (raw)
In-Reply-To: <20190408180110.GA15199@archlinux-ryzen>
On Mon, Apr 08, 2019 at 11:01:10AM -0700, Nathan Chancellor wrote:
> On Thu, Mar 21, 2019 at 11:09:09PM +0800, Yue Haibing wrote:
> > From: YueHaibing <yuehaibing@huawei.com>
> > -void artpec6_pmx_disable(struct pinctrl_dev *pctldev, unsigned int function,
> > - unsigned int group)
> > +static void artpec6_pmx_disable(struct pinctrl_dev *pctldev,
> > + unsigned int function,
> > + unsigned int group)
>
> On arm32 allyesconfig:
>
> drivers/pinctrl/pinctrl-artpec6.c:706:13: error: unused function
> 'artpec6_pmx_disable' [-Werror,-Wunused-function]
>
> This is the second time you've introduced an unused function warning by
> making a function static[1], could you please be a little more vigilant
> in your clean ups in the future?
>
> [1]: https://lore.kernel.org/lkml/20190327050126.12064-1-natechancellor@gmail.com/
>
> Linus/Jesper/Lars, should this function just be deleted? I'd be happy to
> send a patch doing so if that's the right course of action.
Yes, that function is unused and can be dropped.
> Thanks,
> Nathan
/^JN - Jesper Nilsson
--
Jesper Nilsson -- jesper.nilsson@axis.com
prev parent reply other threads:[~2019-04-09 6:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 15:09 Yue Haibing
2019-03-21 15:59 ` Jesper Nilsson
2019-04-04 15:26 ` Linus Walleij
2019-04-08 18:01 ` Nathan Chancellor
2019-04-09 1:35 ` YueHaibing
2019-04-09 6:56 ` Jesper Nilsson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409065621.2yfx5nqzpuxyj46p@axis.com \
--to=jesper.nilsson@axis.com \
--cc=jespern@axis.com \
--cc=larper@axis.com \
--cc=linus.walleij@linaro.org \
--cc=linux-arm-kernel@axis.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®