* Re: [PATCH] jbd2: remove repeated assignments in __jbd2_log_wait_for_space
[not found] <20190327143135.2784-1-fishland@aliyun.com>
@ 2019-03-27 16:25 ` Jan Kara
0 siblings, 0 replies; only message in thread
From: Jan Kara @ 2019-03-27 16:25 UTC (permalink / raw)
To: Liu Song; +Cc: tytso, jack, linux-ext4, linux-kernel, liu.song11
On Wed 27-03-19 22:31:35, Liu Song wrote:
> From: Liu Song <liu.song11@zte.com.cn>
>
> At the beginning, nblocks has been assigned. There is no need
> to repeat the assignment in the while loop, and remove it.
>
> Signed-off-by: Liu Song <liu.song11@zte.com.cn>
Looks good. You can add:
Reviewed-by: Jan Kara <jack@suse.cz>
Honza
> ---
> fs/jbd2/checkpoint.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/fs/jbd2/checkpoint.c b/fs/jbd2/checkpoint.c
> index 26f8d7e46462..23053de5e999 100644
> --- a/fs/jbd2/checkpoint.c
> +++ b/fs/jbd2/checkpoint.c
> @@ -132,7 +132,6 @@ void __jbd2_log_wait_for_space(journal_t *journal)
> return;
> }
> spin_lock(&journal->j_list_lock);
> - nblocks = jbd2_space_needed(journal);
> space_left = jbd2_log_space_left(journal);
> if (space_left < nblocks) {
> int chkpt = journal->j_checkpoint_transactions != NULL;
> --
> 2.19.1
>
>
--
Jan Kara <jack@suse.com>
SUSE Labs, CR
^ permalink raw reply [flat|nested] only message in thread