* [PATCH net-next] net: mvneta: Add 2500BaseT support
@ 2019-03-27 16:31 Maxime Chevallier
2019-03-29 0:02 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Maxime Chevallier @ 2019-03-27 16:31 UTC (permalink / raw)
To: davem
Cc: Maxime Chevallier, netdev, linux-kernel, Antoine Tenart,
thomas.petazzoni, gregory.clement, miquel.raynal, nadavh,
stefanc, mw, Russell King, linux-arm-kernel, Andrew Lunn
Some PHYs will use the 2500BaseX PHY_INTERFACE_MODE when being linked
with a partner using 2.5GBaseT.
Since we can't autonegotiate this speed between the MAC and the PHY, we
need to have the proper comphy support enabled, to make sure we can
safely advertise 2.5G and 1G in BaseT and be able to switch between both
corresponding PHY interface modes. This is now possible since comphy
support was added to this driver.
This commit adds the 2500BaseT mode to the list of supported modes when
using 2500BaseX, and was tested on a setup with an Armada385 and a
88E2010 PHY, both with and without the comphy node in the DT.
Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
---
drivers/net/ethernet/marvell/mvneta.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/ethernet/marvell/mvneta.c b/drivers/net/ethernet/marvell/mvneta.c
index c0a3718b2e2a..a944be3c57b1 100644
--- a/drivers/net/ethernet/marvell/mvneta.c
+++ b/drivers/net/ethernet/marvell/mvneta.c
@@ -3385,6 +3385,7 @@ static void mvneta_validate(struct net_device *ndev, unsigned long *supported,
phylink_set(mask, 1000baseX_Full);
}
if (pp->comphy || state->interface == PHY_INTERFACE_MODE_2500BASEX) {
+ phylink_set(mask, 2500baseT_Full);
phylink_set(mask, 2500baseX_Full);
}
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH net-next] net: mvneta: Add 2500BaseT support
2019-03-27 16:31 [PATCH net-next] net: mvneta: Add 2500BaseT support Maxime Chevallier
@ 2019-03-29 0:02 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2019-03-29 0:02 UTC (permalink / raw)
To: maxime.chevallier
Cc: netdev, linux-kernel, antoine.tenart, thomas.petazzoni,
gregory.clement, miquel.raynal, nadavh, stefanc, mw, linux,
linux-arm-kernel, andrew
From: Maxime Chevallier <maxime.chevallier@bootlin.com>
Date: Wed, 27 Mar 2019 17:31:06 +0100
> Some PHYs will use the 2500BaseX PHY_INTERFACE_MODE when being linked
> with a partner using 2.5GBaseT.
>
> Since we can't autonegotiate this speed between the MAC and the PHY, we
> need to have the proper comphy support enabled, to make sure we can
> safely advertise 2.5G and 1G in BaseT and be able to switch between both
> corresponding PHY interface modes. This is now possible since comphy
> support was added to this driver.
>
> This commit adds the 2500BaseT mode to the list of supported modes when
> using 2500BaseX, and was tested on a setup with an Armada385 and a
> 88E2010 PHY, both with and without the comphy node in the DT.
>
> Signed-off-by: Maxime Chevallier <maxime.chevallier@bootlin.com>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-29 0:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-27 16:31 [PATCH net-next] net: mvneta: Add 2500BaseT support Maxime Chevallier
2019-03-29 0:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®