From: Luis Ressel <aranea@aixah.de>
To: Josh Poimboeuf <jpoimboe@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org (open list)
Cc: Luis Ressel <aranea@aixah.de>, stable@vger.kernel.org
Subject: [PATCH] objtool: Don't use -Werror
Date: Fri, 5 Apr 2019 13:01:50 +0200 [thread overview]
Message-ID: <20190405110151.2461-1-aranea@aixah.de> (raw)
-Werror can be handy for development, but enabling it for production
builds is a bad idea -- other compilers might produce unexpected
warnings, or #included library headers might trigger warnings.
In my case, libelf's (not elfutil's!) headers trigger several -Wundef
warnings. This wasn't a problem before 056d28d135bc, since gcc doesn't
emit warnings for system headers, but now that there's a
-I/usr/include/libelf/ in the gcc command line, those warnings appear
and break the build.
CC'ing stable@ since 056d28d135bc has also been included in stable
versions.
Fixes: 056d28d135bc ("objtool: Query pkg-config for libelf location")
Signed-off-by: Luis Ressel <aranea@aixah.de>
Cc: stable@vger.kernel.org
---
tools/objtool/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/objtool/Makefile b/tools/objtool/Makefile
index 53f8be0f4a1f..ad2c11a881db 100644
--- a/tools/objtool/Makefile
+++ b/tools/objtool/Makefile
@@ -34,7 +34,7 @@ INCLUDES := -I$(srctree)/tools/include \
-I$(srctree)/tools/arch/$(HOSTARCH)/include/uapi \
-I$(srctree)/tools/objtool/arch/$(ARCH)/include
WARNINGS := $(EXTRA_WARNINGS) -Wno-switch-default -Wno-switch-enum -Wno-packed
-CFLAGS += -Werror $(WARNINGS) $(KBUILD_HOSTCFLAGS) -g $(INCLUDES) $(LIBELF_FLAGS)
+CFLAGS += $(WARNINGS) $(KBUILD_HOSTCFLAGS) -g $(INCLUDES) $(LIBELF_FLAGS)
LDFLAGS += $(LIBELF_LIBS) $(LIBSUBCMD) $(KBUILD_HOSTLDFLAGS)
# Allow old libelf to be used:
--
2.21.0
next reply other threads:[~2019-04-05 11:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 11:01 Luis Ressel [this message]
2019-04-05 12:39 ` Josh Poimboeuf
2019-04-05 14:24 ` Luis Ressel
2019-04-05 14:39 ` Josh Poimboeuf
2019-04-05 16:05 ` Luis Ressel
2019-04-05 16:15 ` Josh Poimboeuf
2019-04-05 16:30 ` Luis Ressel
2019-04-05 16:16 ` David Laight
2019-04-05 16:21 ` Josh Poimboeuf
2019-04-05 16:35 ` David Laight
2019-04-05 17:12 ` Josh Poimboeuf
2019-04-05 17:17 ` David Laight
2019-04-05 17:22 ` Josh Poimboeuf
2019-04-08 9:20 ` David Laight
2019-04-08 13:02 ` Josh Poimboeuf
2019-04-05 16:26 ` 'Luis Ressel'
2019-04-05 16:35 ` 'Luis Ressel'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405110151.2461-1-aranea@aixah.de \
--to=aranea@aixah.de \
--cc=jpoimboe@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®