From: Josh Poimboeuf <jpoimboe@redhat.com>
To: David Laight <David.Laight@ACULAB.COM>
Cc: 'Luis Ressel' <aranea@aixah.de>,
Peter Zijlstra <peterz@infradead.org>,
open list <linux-kernel@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>
Subject: Re: [PATCH] objtool: Don't use -Werror
Date: Fri, 5 Apr 2019 12:12:07 -0500 [thread overview]
Message-ID: <20190405171207.jmi7zehu37ksg5a4@treble> (raw)
In-Reply-To: <d3cb290b12974f1895ea235680f90ead@AcuMS.aculab.com>
On Fri, Apr 05, 2019 at 04:35:50PM +0000, David Laight wrote:
> From: Josh Poimboeuf
> > Sent: 05 April 2019 17:21
> ..
> > > FWIW I had to update libelf.so from version 0.153 to 0.165 in
> > > order for the amd64 orc unwinder code in objtool to not generate
> > > corrupt output files.
> > > That is an Ubuntu 13.04 system - nothing like 10 years old.
> >
> > Ah. It would be great if we had a patch to fail the build for old
> > versions of elfutils-libelf as well.
>
> I think the check I added for that specific error got committed.
> Look at the defintion of cmd_objtool in scripts/Makefile.build.
>
> Although I seem to have a local change to the definition of
> cmd_modversions_c.
> It might be that the version of a change I made that got committed
> is missing an extra $ when processing the saved output from 'objdump -h'.
> It used to just pipe into grep - so lost the error result from objdump.
Hm, I don't see that in cmd_objtool, or any commits from you in
scripts/Makefile.build.
--
Josh
next prev parent reply other threads:[~2019-04-05 17:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-05 11:01 Luis Ressel
2019-04-05 12:39 ` Josh Poimboeuf
2019-04-05 14:24 ` Luis Ressel
2019-04-05 14:39 ` Josh Poimboeuf
2019-04-05 16:05 ` Luis Ressel
2019-04-05 16:15 ` Josh Poimboeuf
2019-04-05 16:30 ` Luis Ressel
2019-04-05 16:16 ` David Laight
2019-04-05 16:21 ` Josh Poimboeuf
2019-04-05 16:35 ` David Laight
2019-04-05 17:12 ` Josh Poimboeuf [this message]
2019-04-05 17:17 ` David Laight
2019-04-05 17:22 ` Josh Poimboeuf
2019-04-08 9:20 ` David Laight
2019-04-08 13:02 ` Josh Poimboeuf
2019-04-05 16:26 ` 'Luis Ressel'
2019-04-05 16:35 ` 'Luis Ressel'
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190405171207.jmi7zehu37ksg5a4@treble \
--to=jpoimboe@redhat.com \
--cc=David.Laight@ACULAB.COM \
--cc=aranea@aixah.de \
--cc=linux-kernel@vger.kernel.org \
--cc=peterz@infradead.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®