From: Borislav Petkov <bp@alien8.de>
To: Gary R Hook <ghook@amd.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
"Hook, Gary" <Gary.Hook@amd.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"peterz@infradead.org" <peterz@infradead.org>,
"x86@kernel.org" <x86@kernel.org>,
"mingo@redhat.com" <mingo@redhat.com>,
"luto@kernel.org" <luto@kernel.org>,
Alexander Potapenko <glider@google.com>
Subject: Re: [PATCH] x86/mm/mem_encrypt: Disable all instrumentation for SME early boot code
Date: Mon, 8 Apr 2019 18:58:35 +0200 [thread overview]
Message-ID: <20190408165835.GJ15689@zn.tnic> (raw)
In-Reply-To: <5dfcb133-0a0e-9e07-3774-313e30814e79@amd.com>
On Mon, Apr 08, 2019 at 04:46:31PM +0000, Gary R Hook wrote:
> My reasoning (not arguing): the file has been touched exactly one time
> in 4 years, by Thomas. Doesn't appear to be a candidate for constant
> modification, so this approach doesn't seem risky to me. I could be wrong.
The problem, like we discussed it with Tom offlist, is that you simply
cannot turn off instrumentation for those generic files just because SME
has trouble with them, and that last thing can be any vendor-specific
feature.
Even if the functions there are "trivial" now (doesn't mean new stuff
won't be added there in the future and we forget about the disabled
instrumentation here.)
We simply cannot constrain generic compilation units like that. So the
functions there either need to be copied or ifdeffed. At the time SME
was going in, the intention was to reuse code so that there is less
duplication. But if there's trouble doing that sharing, then we need to
"unshare" it again. Or come up with something else slick and clean.
Thx.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
next prev parent reply other threads:[~2019-04-08 16:58 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-04 20:26 Hook, Gary
2019-04-04 20:42 ` Thomas Gleixner
2019-04-08 16:46 ` Gary R Hook
2019-04-08 16:58 ` Borislav Petkov [this message]
2019-04-08 18:41 ` Gary R Hook
2019-04-08 19:08 ` Borislav Petkov
2019-04-09 13:47 ` Lendacky, Thomas
2019-04-26 15:11 ` Gary R Hook
2019-04-26 16:24 ` Borislav Petkov
2019-04-29 20:16 ` Gary R Hook
2019-04-29 20:51 ` Borislav Petkov
2019-04-29 21:22 ` Gary R Hook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190408165835.GJ15689@zn.tnic \
--to=bp@alien8.de \
--cc=Gary.Hook@amd.com \
--cc=dave.hansen@linux.intel.com \
--cc=ghook@amd.com \
--cc=glider@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®