From: Christoph Hellwig <hch@lst.de>
To: Maximilian Heyne <mheyne@amazon.de>
Cc: David Woodhouse <dwmw2@infradead.org>, Amit Shah <aams@amazon.de>,
Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>, Sagi Grimberg <sagi@grimberg.me>,
James Smart <james.smart@broadcom.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] nvme: add sysfs controls for io and admin timeouts
Date: Tue, 9 Apr 2019 12:23:07 +0200 [thread overview]
Message-ID: <20190409102307.GA7741@lst.de> (raw)
In-Reply-To: <20190403123506.122904-3-mheyne@amazon.de>
I really don't think the iteration over all queues of a tagset
makes a whole lot of sense. We really need to replace the per-queue
limit with a per-tagset one (or at least add the per-tagset one)
and then allow tweaking that in the block layer instead of writing
this boiler plate code.
next prev parent reply other threads:[~2019-04-09 10:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 12:35 [PATCH v2 0/2] Adding per-controller timeout support to nvme Maximilian Heyne
2019-04-03 12:35 ` [PATCH v2 1/2] nvme: add per-controller io and admin timeouts Maximilian Heyne
2019-04-03 12:35 ` [PATCH v2 2/2] nvme: add sysfs controls for " Maximilian Heyne
2019-04-09 10:23 ` Christoph Hellwig [this message]
2019-04-24 16:55 ` [PATCH v2 0/2] Adding per-controller timeout support to nvme Sagi Grimberg
2019-04-24 20:07 ` Keith Busch
2019-04-24 20:30 ` David Woodhouse
2019-04-24 20:44 ` Keith Busch
2019-04-24 20:58 ` Sagi Grimberg
2019-04-25 5:45 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409102307.GA7741@lst.de \
--to=hch@lst.de \
--cc=aams@amazon.de \
--cc=axboe@fb.com \
--cc=dwmw2@infradead.org \
--cc=james.smart@broadcom.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mheyne@amazon.de \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome