From: Keith Busch <kbusch@kernel.org>
To: Sagi Grimberg <sagi@grimberg.me>
Cc: Maximilian Heyne <mheyne@amazon.de>,
David Woodhouse <dwmw2@infradead.org>, Amit Shah <aams@amazon.de>,
Keith Busch <keith.busch@intel.com>, Jens Axboe <axboe@fb.com>,
Christoph Hellwig <hch@lst.de>,
James Smart <james.smart@broadcom.com>,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Adding per-controller timeout support to nvme
Date: Wed, 24 Apr 2019 14:07:06 -0600 [thread overview]
Message-ID: <20190424200706.GB15412@localhost.localdomain> (raw)
In-Reply-To: <fb33a464-af65-abec-5ff1-15925e7669a4@grimberg.me>
On Wed, Apr 24, 2019 at 09:55:16AM -0700, Sagi Grimberg wrote:
>
> > As different nvme controllers are connect via different fabrics, some require
> > different timeout settings than others. This series implements per-controller
> > timeouts in the nvme subsystem which can be set via sysfs.
>
> How much of a real issue is this?
>
> block io_timeout defaults to 30 seconds which are considered a universal
> eternity for pretty much any nvme fabric. Moreover, io_timeout is
> mutable already on a per-namespace level.
>
> This leaves the admin_timeout which goes beyond this to 60 seconds...
>
> Can you describe what exactly are you trying to solve?
I think they must have an nvme target that is backed by slow media
(i.e. non-SSD). If that's the case, I think it may be a better option
if the target advertises relatively shallow queue depths and/or lower
MDTS that better aligns to the backing storage capabilies.
next prev parent reply other threads:[~2019-04-24 20:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-03 12:35 Maximilian Heyne
2019-04-03 12:35 ` [PATCH v2 1/2] nvme: add per-controller io and admin timeouts Maximilian Heyne
2019-04-03 12:35 ` [PATCH v2 2/2] nvme: add sysfs controls for " Maximilian Heyne
2019-04-09 10:23 ` Christoph Hellwig
2019-04-24 16:55 ` [PATCH v2 0/2] Adding per-controller timeout support to nvme Sagi Grimberg
2019-04-24 20:07 ` Keith Busch [this message]
2019-04-24 20:30 ` David Woodhouse
2019-04-24 20:44 ` Keith Busch
2019-04-24 20:58 ` Sagi Grimberg
2019-04-25 5:45 ` David Woodhouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190424200706.GB15412@localhost.localdomain \
--to=kbusch@kernel.org \
--cc=aams@amazon.de \
--cc=axboe@fb.com \
--cc=dwmw2@infradead.org \
--cc=hch@lst.de \
--cc=james.smart@broadcom.com \
--cc=keith.busch@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=mheyne@amazon.de \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome