[PATCH] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls

mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed

* [PATCH] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view
@ 2019-04-09  6:25 Adrian Hunter
  2019-04-09 15:01 ` Arnaldo Carvalho de Melo
                   ` (2 more replies)
  0 siblings, 3 replies; 4+ messages in thread
From: Adrian Hunter @ 2019-04-09  6:25 UTC (permalink / raw)
  To: Arnaldo Carvalho de Melo; +Cc: Jiri Olsa, linux-kernel

Fix following error using calls_view:
 Query failed: ambiguous column name: parent_id Unable to execute statement

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Fixes: 8ce9a7251d11 ("perf scripts python: export-to-sqlite.py: Export calls parent_id")
---
 tools/perf/scripts/python/export-to-sqlite.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/scripts/python/export-to-sqlite.py b/tools/perf/scripts/python/export-to-sqlite.py
index 3b71902a5a21..bf271fbc3a88 100644
--- a/tools/perf/scripts/python/export-to-sqlite.py
+++ b/tools/perf/scripts/python/export-to-sqlite.py
@@ -331,7 +331,7 @@ if perf_db_export_calls:
 			'return_id,'
 			'CASE WHEN flags=0 THEN \'\' WHEN flags=1 THEN \'no call\' WHEN flags=2 THEN \'no return\' WHEN flags=3 THEN \'no call/return\' WHEN flags=6 THEN \'jump\' ELSE flags END AS flags,'
 			'parent_call_path_id,'
-			'parent_id'
+			'calls.parent_id'
 		' FROM calls INNER JOIN call_paths ON call_paths.id = call_path_id')
 
 do_query(query, 'CREATE VIEW samples_view AS '
-- 
2.17.1


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view
  2019-04-09  6:25 [PATCH] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view Adrian Hunter
@ 2019-04-09 15:01 ` Arnaldo Carvalho de Melo
  2019-04-12 16:38 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
  2019-04-16 15:28 ` tip-bot for Adrian Hunter
  2 siblings, 0 replies; 4+ messages in thread
From: Arnaldo Carvalho de Melo @ 2019-04-09 15:01 UTC (permalink / raw)
  To: Adrian Hunter; +Cc: Jiri Olsa, linux-kernel

Em Tue, Apr 09, 2019 at 09:25:57AM +0300, Adrian Hunter escreveu:
> Fix following error using calls_view:
>  Query failed: ambiguous column name: parent_id Unable to execute statement
> 
> Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>

Applied, and thanks for the Fixes tag, appreciated,

- Arnaldo

> Fixes: 8ce9a7251d11 ("perf scripts python: export-to-sqlite.py: Export calls parent_id")
> ---
>  tools/perf/scripts/python/export-to-sqlite.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/perf/scripts/python/export-to-sqlite.py b/tools/perf/scripts/python/export-to-sqlite.py
> index 3b71902a5a21..bf271fbc3a88 100644
> --- a/tools/perf/scripts/python/export-to-sqlite.py
> +++ b/tools/perf/scripts/python/export-to-sqlite.py
> @@ -331,7 +331,7 @@ if perf_db_export_calls:
>  			'return_id,'
>  			'CASE WHEN flags=0 THEN \'\' WHEN flags=1 THEN \'no call\' WHEN flags=2 THEN \'no return\' WHEN flags=3 THEN \'no call/return\' WHEN flags=6 THEN \'jump\' ELSE flags END AS flags,'
>  			'parent_call_path_id,'
> -			'parent_id'
> +			'calls.parent_id'
>  		' FROM calls INNER JOIN call_paths ON call_paths.id = call_path_id')
>  
>  do_query(query, 'CREATE VIEW samples_view AS '
> -- 
> 2.17.1

-- 

- Arnaldo

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [tip:perf/urgent] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view
  2019-04-09  6:25 [PATCH] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view Adrian Hunter
  2019-04-09 15:01 ` Arnaldo Carvalho de Melo
@ 2019-04-12 16:38 ` tip-bot for Adrian Hunter
  2019-04-16 15:28 ` tip-bot for Adrian Hunter
  2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Adrian Hunter @ 2019-04-12 16:38 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: hpa, tglx, adrian.hunter, mingo, acme, jolsa, linux-kernel

Commit-ID:  961df45e5de662e65fc6bc415fecc8caa8a3045c
Gitweb:     https://git.kernel.org/tip/961df45e5de662e65fc6bc415fecc8caa8a3045c
Author:     Adrian Hunter <adrian.hunter@intel.com>
AuthorDate: Tue, 9 Apr 2019 09:25:57 +0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 9 Apr 2019 10:15:00 -0300

perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view

Fix following error using calls_view:

 Query failed: ambiguous column name: parent_id Unable to execute statement

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Fixes: 8ce9a7251d11 ("perf scripts python: export-to-sqlite.py: Export calls parent_id")
Link: http://lkml.kernel.org/r/20190409062557.26138-1-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/scripts/python/export-to-sqlite.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/scripts/python/export-to-sqlite.py b/tools/perf/scripts/python/export-to-sqlite.py
index 3b71902a5a21..bf271fbc3a88 100644
--- a/tools/perf/scripts/python/export-to-sqlite.py
+++ b/tools/perf/scripts/python/export-to-sqlite.py
@@ -331,7 +331,7 @@ if perf_db_export_calls:
 			'return_id,'
 			'CASE WHEN flags=0 THEN \'\' WHEN flags=1 THEN \'no call\' WHEN flags=2 THEN \'no return\' WHEN flags=3 THEN \'no call/return\' WHEN flags=6 THEN \'jump\' ELSE flags END AS flags,'
 			'parent_call_path_id,'
-			'parent_id'
+			'calls.parent_id'
 		' FROM calls INNER JOIN call_paths ON call_paths.id = call_path_id')
 
 do_query(query, 'CREATE VIEW samples_view AS '

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [tip:perf/urgent] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view
  2019-04-09  6:25 [PATCH] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view Adrian Hunter
  2019-04-09 15:01 ` Arnaldo Carvalho de Melo
  2019-04-12 16:38 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
@ 2019-04-16 15:28 ` tip-bot for Adrian Hunter
  2 siblings, 0 replies; 4+ messages in thread
From: tip-bot for Adrian Hunter @ 2019-04-16 15:28 UTC (permalink / raw)
  To: linux-tip-commits
  Cc: adrian.hunter, acme, linux-kernel, jolsa, mingo, tglx, hpa

Commit-ID:  6e4b1cac30d297718218dc268199ed20df074b98
Gitweb:     https://git.kernel.org/tip/6e4b1cac30d297718218dc268199ed20df074b98
Author:     Adrian Hunter <adrian.hunter@intel.com>
AuthorDate: Tue, 9 Apr 2019 09:25:57 +0300
Committer:  Arnaldo Carvalho de Melo <acme@redhat.com>
CommitDate: Tue, 16 Apr 2019 11:27:05 -0300

perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view

Fix following error using calls_view:

 Query failed: ambiguous column name: parent_id Unable to execute statement

Signed-off-by: Adrian Hunter <adrian.hunter@intel.com>
Cc: Jiri Olsa <jolsa@redhat.com>
Fixes: 8ce9a7251d11 ("perf scripts python: export-to-sqlite.py: Export calls parent_id")
Link: http://lkml.kernel.org/r/20190409062557.26138-1-adrian.hunter@intel.com
Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
---
 tools/perf/scripts/python/export-to-sqlite.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/scripts/python/export-to-sqlite.py b/tools/perf/scripts/python/export-to-sqlite.py
index 3b71902a5a21..bf271fbc3a88 100644
--- a/tools/perf/scripts/python/export-to-sqlite.py
+++ b/tools/perf/scripts/python/export-to-sqlite.py
@@ -331,7 +331,7 @@ if perf_db_export_calls:
 			'return_id,'
 			'CASE WHEN flags=0 THEN \'\' WHEN flags=1 THEN \'no call\' WHEN flags=2 THEN \'no return\' WHEN flags=3 THEN \'no call/return\' WHEN flags=6 THEN \'jump\' ELSE flags END AS flags,'
 			'parent_call_path_id,'
-			'parent_id'
+			'calls.parent_id'
 		' FROM calls INNER JOIN call_paths ON call_paths.id = call_path_id')
 
 do_query(query, 'CREATE VIEW samples_view AS '

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-04-16 15:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09  6:25 [PATCH] perf scripts python: export-to-sqlite.py: Fix use of parent_id in calls_view Adrian Hunter
2019-04-09 15:01 ` Arnaldo Carvalho de Melo
2019-04-12 16:38 ` [tip:perf/urgent] " tip-bot for Adrian Hunter
2019-04-16 15:28 ` tip-bot for Adrian Hunter

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome