From: Erwan Velu <erwanaliasr1@gmail.com>
To: unlisted-recipients:; (no To-header on input)
Cc: Erwan Velu <e.velu@criteo.com>,
Kashyap Desai <kashyap.desai@broadcom.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Shivasharan S <shivasharan.srikanteshwara@broadcom.com>,
"James E.J. Bottomley" <jejb@linux.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
megaraidlinux.pdl@broadcom.com (open list:MEGARAID SCSI/SAS
DRIVERS),
linux-scsi@vger.kernel.org (open list:MEGARAID SCSI/SAS DRIVERS),
linux-kernel@vger.kernel.org (open list)
Subject: [PATCH] scsi: megaraid_sas: Reporting evt_detail->code in megasas_decode_evt
Date: Tue, 9 Apr 2019 17:23:38 +0200 [thread overview]
Message-ID: <20190409152338.27874-1-e.velu@criteo.com> (raw)
When printing a megasas_decode_evt() message, the code member of the evt_detail is not reported.
This make the debugging more complicated as some code paths depends on this value.
Reporting the code member makes the context more explicit.
Signed-off-by: Erwan Velu <e.velu@criteo.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 293f5cf524d7..222166c659bb 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -392,8 +392,9 @@ megasas_decode_evt(struct megasas_instance *instance)
class_locale.word = le32_to_cpu(evt_detail->cl.word);
if (class_locale.members.class >= MFI_EVT_CLASS_CRITICAL)
- dev_info(&instance->pdev->dev, "%d (%s/0x%04x/%s) - %s\n",
+ dev_info(&instance->pdev->dev, "%d code:%d (%s/0x%04x/%s) - %s\n",
le32_to_cpu(evt_detail->seq_num),
+ le32_to_cpu(instance->evt_detail->code),
format_timestamp(le32_to_cpu(evt_detail->time_stamp)),
(class_locale.members.locale),
format_class(class_locale.members.class),
--
2.21.0
reply other threads:[~2019-04-09 15:24 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190409152338.27874-1-e.velu@criteo.com \
--to=erwanaliasr1@gmail.com \
--cc=e.velu@criteo.com \
--cc=jejb@linux.ibm.com \
--cc=kashyap.desai@broadcom.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=megaraidlinux.pdl@broadcom.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®