mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] scsi: megaraid_sas: Reporting evt_detail->code in megasas_decode_evt
@ 2019-04-09 15:23 Erwan Velu
  0 siblings, 0 replies; only message in thread
From: Erwan Velu @ 2019-04-09 15:23 UTC (permalink / raw)
  Cc: Erwan Velu, Kashyap Desai, Sumit Saxena, Shivasharan S,
	James E.J. Bottomley, Martin K. Petersen,
	open list:MEGARAID SCSI/SAS DRIVERS,
	open list:MEGARAID SCSI/SAS DRIVERS, open list

When printing a megasas_decode_evt() message, the code member of the evt_detail is not reported.
This make the debugging more complicated as some code paths depends on this value.

Reporting the code member makes the context more explicit.

Signed-off-by: Erwan Velu <e.velu@criteo.com>
---
 drivers/scsi/megaraid/megaraid_sas_base.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 293f5cf524d7..222166c659bb 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -392,8 +392,9 @@ megasas_decode_evt(struct megasas_instance *instance)
 	class_locale.word = le32_to_cpu(evt_detail->cl.word);
 
 	if (class_locale.members.class >= MFI_EVT_CLASS_CRITICAL)
-		dev_info(&instance->pdev->dev, "%d (%s/0x%04x/%s) - %s\n",
+		dev_info(&instance->pdev->dev, "%d code:%d (%s/0x%04x/%s) - %s\n",
 			le32_to_cpu(evt_detail->seq_num),
+			le32_to_cpu(instance->evt_detail->code),
 			format_timestamp(le32_to_cpu(evt_detail->time_stamp)),
 			(class_locale.members.locale),
 			format_class(class_locale.members.class),
-- 
2.21.0


^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2019-04-09 15:24 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-04-09 15:23 [PATCH] scsi: megaraid_sas: Reporting evt_detail->code in megasas_decode_evt Erwan Velu

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®