From: Thomas Bogendoerfer <tbogendoerfer@suse.de>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Joshua Kinard <kumba@gentoo.org>,
Alessandro Zummo <a.zummo@towertech.it>,
linux-rtc@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] rtc: ds1685: use correct device struct to get platform device struct
Date: Fri, 12 Apr 2019 13:44:59 +0200 [thread overview]
Message-ID: <20190412134459.446ef705c86aa1c7b926abc7@suse.de> (raw)
In-Reply-To: <20190412101106.GU3578@piout.net>
On Fri, 12 Apr 2019 12:11:06 +0200
Alexandre Belloni <alexandre.belloni@bootlin.com> wrote:
> Every patch need a commit message. Maybe you could indicate that this
> never gave any issue because parent is the first member of struct
> device.
I'll update the commit message, I get a nice stacktrace because of that
bug, so the path from work_queue calling ds1685_rtc_poweroff never worked.
Thomas.
--
SUSE Linux GmbH
GF: Felix Imendörffer, Mary Higgins, Sri Rasiah
HRB 21284 (AG Nürnberg)
next prev parent reply other threads:[~2019-04-12 11:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-11 14:33 [PATCH 1/3] rtc: ds1685: fix crash caused by referencing wrong " Thomas Bogendoerfer
2019-04-11 14:33 ` [PATCH 2/3] rtc: ds1685: use correct device struct to get platform " Thomas Bogendoerfer
2019-04-12 10:11 ` Alexandre Belloni
2019-04-12 11:44 ` Thomas Bogendoerfer [this message]
2019-04-13 5:17 ` Joshua Kinard
2019-04-13 8:19 ` Thomas Bogendoerfer
2019-04-11 14:33 ` [PATCH 3/3] rtc: ds1685: disable interrupts when moving work to work queue Thomas Bogendoerfer
2019-04-12 10:14 ` Alexandre Belloni
2019-04-12 11:49 ` Thomas Bogendoerfer
2019-04-12 10:14 ` [PATCH 1/3] rtc: ds1685: fix crash caused by referencing wrong device struct Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190412134459.446ef705c86aa1c7b926abc7@suse.de \
--to=tbogendoerfer@suse.de \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=kumba@gentoo.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®