From: Jia-Ju Bai <baijiaju1990@gmail.com>
To: davem@davemloft.net
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
Jia-Ju Bai <baijiaju1990@gmail.com>
Subject: [PATCH] net: via-rhine: net: Fix a resource leak in rhine_init()
Date: Sat, 4 May 2019 11:08:13 +0800 [thread overview]
Message-ID: <20190504030813.17684-1-baijiaju1990@gmail.com> (raw)
When platform_driver_register() fails, pci_unregister_driver() is not
called to release the resource allocated by pci_register_driver().
To fix this bug, error handling code for platform_driver_register() and
pci_register_driver() is separately implemented.
This bug is found by a runtime fuzzing tool named FIZZER written by us.
Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
---
drivers/net/ethernet/via/via-rhine.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/via/via-rhine.c b/drivers/net/ethernet/via/via-rhine.c
index 33949248c829..eb74e5a03aac 100644
--- a/drivers/net/ethernet/via/via-rhine.c
+++ b/drivers/net/ethernet/via/via-rhine.c
@@ -2633,10 +2633,15 @@ static int __init rhine_init(void)
pr_info("avoid_D3 set\n");
ret_pci = pci_register_driver(&rhine_driver_pci);
- ret_platform = platform_driver_register(&rhine_driver_platform);
- if ((ret_pci < 0) && (ret_platform < 0))
+ if (ret_pci)
return ret_pci;
+ ret_platform = platform_driver_register(&rhine_driver_platform);
+ if (ret_platform) {
+ pci_unregister_driver(&rhine_driver_pci);
+ return ret_platform;
+ }
+
return 0;
}
--
2.17.0
next reply other threads:[~2019-05-04 3:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-04 3:08 Jia-Ju Bai [this message]
2019-05-04 3:13 ` David Miller
2019-05-04 3:23 ` Jia-Ju Bai
2019-05-04 3:41 ` David Miller
2019-05-04 3:57 ` Jia-Ju Bai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190504030813.17684-1-baijiaju1990@gmail.com \
--to=baijiaju1990@gmail.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®