From: Steven Rostedt <rostedt@goodmis.org>
To: Qais Yousef <qais.yousef@arm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>,
linux-kernel@vger.kernel.org,
Pavankumar Kondeti <pkondeti@codeaurora.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Uwe Kleine-Konig <u.kleine-koenig@pengutronix.de>
Subject: Re: [PATCH 4/7] sched: Add sched_load_rq tracepoint
Date: Mon, 6 May 2019 10:46:18 -0400 [thread overview]
Message-ID: <20190506104618.2fa49e13@gandalf.local.home> (raw)
In-Reply-To: <20190506144200.z4s63nm7untol2tr@e107158-lin.cambridge.arm.com>
On Mon, 6 May 2019 15:42:00 +0100
Qais Yousef <qais.yousef@arm.com> wrote:
> I can control that for the wrappers I'm introducing. But the actual tracepoint
> get the 'trace_' part prepended automatically by the macros.
>
> ie DECLARE_TRACE(pelt_rq, ...) will automatically generate a function called
> trace_pelt_se(...)
>
> Or am I missing something?
No trace comes from the trace points.
So basically, we are going back to having tracepoints without
associated trace events. Which basically is just saying "we want trace
events here, but don't want an API". Of course, we can create a module
that can attach to them and create the trace events as well.
I'm not a big fan of this, but I'll let Peter decide.
-- Steve
next prev parent reply other threads:[~2019-05-06 14:54 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-05 11:57 [PATCH 0/7] Add new tracepoints required for EAS testing Qais Yousef
2019-05-05 11:57 ` [PATCH 1/7] sched: autogroup: Make autogroup_path() always available Qais Yousef
2019-05-05 11:57 ` [PATCH 2/7] sched: fair: move helper functions into fair.h Qais Yousef
2019-05-05 11:57 ` [PATCH 3/7] sched: fair.h: add a new cfs_rq_tg_path() Qais Yousef
2019-05-05 11:57 ` [PATCH 4/7] sched: Add sched_load_rq tracepoint Qais Yousef
2019-05-06 9:08 ` Peter Zijlstra
2019-05-06 9:18 ` Peter Zijlstra
2019-05-08 13:38 ` Qais Yousef
2019-05-06 13:52 ` Steven Rostedt
2019-05-06 14:42 ` Qais Yousef
2019-05-06 14:46 ` Steven Rostedt [this message]
2019-05-06 15:33 ` Qais Yousef
2019-05-06 16:01 ` Steven Rostedt
2019-05-06 17:23 ` Qais Yousef
2019-05-06 14:38 ` Qais Yousef
2019-05-10 8:51 ` Dietmar Eggemann
2019-05-10 9:14 ` Qais Yousef
2019-05-05 11:57 ` [PATCH 5/7] sched: Add sched_load_se tracepoint Qais Yousef
2019-05-05 11:57 ` [PATCH 6/7] sched: Add sched_overutilized tracepoint Qais Yousef
2019-05-05 11:57 ` [PATCH 7/7] sched: export the newly added tracepoints Qais Yousef
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190506104618.2fa49e13@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=bigeasy@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=pkondeti@codeaurora.org \
--cc=qais.yousef@arm.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®