From: Mark Brown <broonie@kernel.org>
To: "S.j. Wang" <shengjiu.wang@nxp.com>
Cc: "brian.austin@cirrus.com" <brian.austin@cirrus.com>,
"Paul.Handrigan@cirrus.com" <Paul.Handrigan@cirrus.com>,
"lgirdwood@gmail.com" <lgirdwood@gmail.com>,
"perex@perex.cz" <perex@perex.cz>,
"tiwai@suse.com" <tiwai@suse.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ASoC: cs42xx8: Add reset gpio handling
Date: Wed, 8 May 2019 17:12:40 +0900 [thread overview]
Message-ID: <20190508081240.GA14916@sirena.org.uk> (raw)
In-Reply-To: <1556534756-15630-1-git-send-email-shengjiu.wang@nxp.com>
[-- Attachment #1: Type: text/plain, Size: 750 bytes --]
On Mon, Apr 29, 2019 at 10:46:03AM +0000, S.j. Wang wrote:
> + cs42xx8->gpio_reset = of_get_named_gpio(dev->of_node, "gpio-reset", 0);
> + if (gpio_is_valid(cs42xx8->gpio_reset)) {
> + ret = devm_gpio_request_one(dev, cs42xx8->gpio_reset,
> + GPIOF_OUT_INIT_LOW, "cs42xx8 reset");
You should just be able to request the GPIO by name without going
through of_get_named_gpio() using devm_gpio_get().
> @@ -559,6 +577,7 @@ static int cs42xx8_runtime_resume(struct device *dev)
>
> regcache_cache_only(cs42xx8->regmap, false);
>
> + regcache_mark_dirty(cs42xx8->regmap);
> ret = regcache_sync(cs42xx8->regmap);
> if (ret) {
> dev_err(dev, "failed to sync regmap: %d\n", ret);
This looks like an unrelated bugfix.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
next prev parent reply other threads:[~2019-05-08 8:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-29 10:46 S.j. Wang
2019-05-08 8:12 ` Mark Brown [this message]
2019-05-16 5:50 S.j. Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508081240.GA14916@sirena.org.uk \
--to=broonie@kernel.org \
--cc=Paul.Handrigan@cirrus.com \
--cc=alsa-devel@alsa-project.org \
--cc=brian.austin@cirrus.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=shengjiu.wang@nxp.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®