From: "Petr Štetiar" <ynezz@true.cz>
To: Rob Herring <robh+dt@kernel.org>
Cc: netdev <netdev@vger.kernel.org>,
devicetree@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Mark Rutland <mark.rutland@arm.com>, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Florian Fainelli <f.fainelli@gmail.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
Woojung Huh <woojung.huh@microchip.com>,
Microchip Linux Driver Support <UNGLinuxDriver@microchip.com>,
Kunihiko Hayashi <hayashi.kunihiko@socionext.com>,
Masahiro Yamada <yamada.masahiro@socionext.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
Kalle Valo <kvalo@codeaurora.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Heiner Kallweit <hkallweit1@gmail.com>,
Frank Rowand <frowand.list@gmail.com>,
Srinivas Kandagatla <srinivas.kandagatla@linaro.org>,
Maxime Ripard <maxime.ripard@bootlin.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE"
<linux-arm-kernel@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v4 02/10] dt-bindings: doc: reflect new NVMEM of_get_mac_address behaviour
Date: Wed, 8 May 2019 10:41:52 +0200 [thread overview]
Message-ID: <20190508084152.GM81826@meh.true.cz> (raw)
In-Reply-To: <CAL_JsqLt6UFU_6bmh3Pc0taXUgMtAEV7kL7eZU13cLOjoakf=Q@mail.gmail.com>
Rob Herring <robh+dt@kernel.org> [2019-05-07 11:44:57]:
Hi,
> > -- local-mac-address: the driver is designed to use the of_get_mac_address api
> > - only if efuse-mac is 0. When efuse-mac is 0, the MAC
> > - address is obtained from local-mac-address. If this
> > - attribute is not present, then the driver will use a
> > - random MAC address.
> > - "netcp-device label": phandle to the device specification for each of NetCP
> > sub-module attached to this interface.
> >
> > +The MAC address will be determined using the optional properties defined in
> > +ethernet.txt, as provided by the of_get_mac_address API and only if efuse-mac
>
> Don't make references to Linux in bindings. You can talk about
> expectations of client programs (e.g Linux, u-boot, BSD, etc.) though.
I've just tried to reword what was already there, anyway, did I understood
your remark properly, would this be more appropriate?
The MAC address will be determined using the optional properties defined in
ethernet.txt and only if efuse-mac is set to 0. If any of the optional MAC
address properties are not present, then the driver will use random MAC
address.
Thanks!
-- ynezz
next prev parent reply other threads:[~2019-05-08 8:41 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1556893635-18549-1-git-send-email-ynezz@true.cz>
2019-05-03 14:27 ` [PATCH v4 01/10] of_net: add NVMEM support to of_get_mac_address Petr Štetiar
2019-05-03 14:36 ` Maxime Ripard
2019-05-03 15:44 ` Petr Štetiar
2019-05-06 14:04 ` Maxime Ripard
2019-05-03 14:27 ` [PATCH v4 02/10] dt-bindings: doc: reflect new NVMEM of_get_mac_address behaviour Petr Štetiar
2019-05-07 16:44 ` Rob Herring
2019-05-08 8:41 ` Petr Štetiar [this message]
2019-05-08 11:48 ` Andrew Lunn
2019-05-03 14:27 ` [PATCH v4 03/10] net: macb: support of_get_mac_address new ERR_PTR error Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 04/10] net: davinci: " Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 06/10] net: usb: " Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 07/10] net: wireless: " Petr Štetiar
2019-05-06 7:59 ` Kalle Valo
2019-05-03 14:27 ` [PATCH v4 08/10] staging: octeon-ethernet: " Petr Štetiar
2019-05-03 15:32 ` [PATCH v5] " Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 09/10] ARM: Kirkwood: " Petr Štetiar
2019-05-03 14:27 ` [PATCH v4 10/10] powerpc: tsi108: " Petr Štetiar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190508084152.GM81826@meh.true.cz \
--to=ynezz@true.cz \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=frowand.list@gmail.com \
--cc=hayashi.kunihiko@socionext.com \
--cc=hkallweit1@gmail.com \
--cc=jaswinder.singh@linaro.org \
--cc=kvalo@codeaurora.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=maxime.ripard@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
--cc=yamada.masahiro@socionext.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®