From: Josh Poimboeuf <jpoimboe@redhat.com>
To: Jiri Kosina <jikos@kernel.org>
Cc: Steven Rostedt <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>, Miroslav Benes <mbenes@suse.cz>,
Petr Mladek <pmladek@suse.com>,
Joe Lawrence <joe.lawrence@redhat.com>,
live-patching@vger.kernel.org, x86@kernel.org,
Borislav Petkov <bp@alien8.de>
Subject: Re: [RFC][PATCH 3/2] livepatch: remove klp_check_compiler_support()
Date: Fri, 10 May 2019 16:58:39 -0500 [thread overview]
Message-ID: <20190510215839.obcshc5p5zapjc3c@treble> (raw)
In-Reply-To: <nycvar.YFH.7.76.1905102346100.17054@cbobk.fhfr.pm>
On Fri, May 10, 2019 at 11:47:50PM +0200, Jiri Kosina wrote:
> From: Jiri Kosina <jkosina@suse.cz>
>
> The only purpose of klp_check_compiler_support() is to make sure that we
> are not using ftrace on x86 via mcount (because that's executed only after
> prologue has already happened, and that's too late for livepatching
> purposes).
>
> Now that mcount is not supported by ftrace any more, there is no need for
> klp_check_compiler_support() either.
>
> Reported-by: Linus Torvalds <torvalds@linux-foundation.org>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
> ---
>
> I guess it makes most sense to merge this together with mcount removal in
> one go.
Acked-by: Josh Poimboeuf <jpoimboe@redhat.com>
--
Josh
prev parent reply other threads:[~2019-05-10 21:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-10 16:35 [RFC][PATCH 0/2 v2] tracing/x86_32: Remove non DYNAMIC_FTRACE and mcount support Steven Rostedt
2019-05-10 16:35 ` [RFC][PATCH 1/2 v2] ftrace/x86_32: Remove support for non DYNAMIC_FTRACE Steven Rostedt
2019-05-10 16:35 ` [RFC][PATCH 2/2 v2] ftrace/x86: Remove mcount support Steven Rostedt
2019-05-10 16:43 ` [RFC][PATCH 0/2 v2] tracing/x86_32: Remove non DYNAMIC_FTRACE and " Steven Rostedt
2019-05-10 21:47 ` [RFC][PATCH 3/2] livepatch: remove klp_check_compiler_support() Jiri Kosina
2019-05-10 21:54 ` Steven Rostedt
2019-05-10 21:58 ` Josh Poimboeuf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190510215839.obcshc5p5zapjc3c@treble \
--to=jpoimboe@redhat.com \
--cc=bp@alien8.de \
--cc=hpa@zytor.com \
--cc=jikos@kernel.org \
--cc=joe.lawrence@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=live-patching@vger.kernel.org \
--cc=mbenes@suse.cz \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=pmladek@suse.com \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®