[PATCH RESEND V3] ASoC: cs42xx8: add reset-gpio in binding document

[PATCH RESEND V3] ASoC: cs42xx8: add reset-gpio in binding document

[S.j. Wang]

Add reset-gpio property, which is an optional option

Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com>
---
Changes in RESEND v3
- send updated binding document only

Changes in v3
- update binding document.

Changes in v2
- use devm_gpiod_get_optional instead of of_get_named_gpio

 Documentation/devicetree/bindings/sound/cs42xx8.txt | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/Documentation/devicetree/bindings/sound/cs42xx8.txt b/Documentation/devicetree/bindings/sound/cs42xx8.txt
index 8619a156d038..ab8f54095269 100644
--- a/Documentation/devicetree/bindings/sound/cs42xx8.txt
+++ b/Documentation/devicetree/bindings/sound/cs42xx8.txt
@@ -14,6 +14,11 @@ Required properties:
   - VA-supply, VD-supply, VLS-supply, VLC-supply: power supplies for the device,
     as covered in Documentation/devicetree/bindings/regulator/regulator.txt
 
+Optional properties:
+
+  - reset-gpio : a GPIO spec to define which pin is connected to the chip's
+    !RESET pin
+
 Example:
 
 cs42888: codec@48 {
@@ -25,4 +30,5 @@ cs42888: codec@48 {
 	VD-supply = <&reg_audio>;
 	VLS-supply = <&reg_audio>;
 	VLC-supply = <&reg_audio>;
+	reset-gpio = <&pca9557_b 1 1>;
 };
-- 
2.21.0

Re: [PATCH RESEND V3] ASoC: cs42xx8: add reset-gpio in binding document

[Mark Brown]

[-- Attachment #1: Type: text/plain, Size: 365 bytes --]

On Thu, May 16, 2019 at 11:24:12AM +0000, S.j. Wang wrote:

> +Optional properties:
> +
> +  - reset-gpio : a GPIO spec to define which pin is connected to the chip's
> +    !RESET pin

gpio properties are supposed to be called -gpios even if there's a
single GPIO possible due to DT rules.  The code will accept plain -gpio
but the documentation should say gpios.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

RE: [EXT] Re: [PATCH RESEND V3] ASoC: cs42xx8: add reset-gpio in binding document

[S.j. Wang]

Hi

> 
> > +Optional properties:
> > +
> > +  - reset-gpio : a GPIO spec to define which pin is connected to the chip's
> > +    !RESET pin
> 
> gpio properties are supposed to be called -gpios even if there's a single
> GPIO possible due to DT rules.  The code will accept plain -gpio but the
> documentation should say gpios.
Ok, will update in v4 😊

Best regards
Wang shengjiu

Re: [alsa-devel] [PATCH RESEND V3] ASoC: cs42xx8: add reset-gpio in binding document

[Fabio Estevam]

On Thu, May 16, 2019 at 8:25 AM S.j. Wang <shengjiu.wang@nxp.com> wrote:

>  cs42888: codec@48 {
> @@ -25,4 +30,5 @@ cs42888: codec@48 {
>         VD-supply = <&reg_audio>;
>         VLS-supply = <&reg_audio>;
>         VLC-supply = <&reg_audio>;
> +       reset-gpio = <&pca9557_b 1 1>;

Please use GPIO_ACTIVE_LOW instead as it makes the polarity clearer.