From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Masahiro Yamada <yamada.masahiro@socionext.com>
Cc: linux-kbuild@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>, Jessica Yu <jeyu@kernel.org>,
Lucas De Marchi <lucas.demarchi@intel.com>,
Michael Schmitz <schmitzmic@gmail.com>,
Linus Torvalds <torvalds@linux-foundation.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Kees Cook <keescook@chromium.org>,
Bernd Petrovitsch <bernd@petrovitsch.priv.at>,
Alexander Kapshuk <alexander.kapshuk@gmail.com>,
Sam Ravnborg <sam@ravnborg.org>,
Michal Marek <michal.lkml@markovi.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] kbuild: check uniqueness of module names
Date: Mon, 20 May 2019 10:04:37 +1000 [thread overview]
Message-ID: <20190520100437.54142214@canb.auug.org.au> (raw)
In-Reply-To: <1558109235-23042-1-git-send-email-yamada.masahiro@socionext.com>
[-- Attachment #1: Type: text/plain, Size: 682 bytes --]
Hi Masahiro,
On Sat, 18 May 2019 01:07:15 +0900 Masahiro Yamada <yamada.masahiro@socionext.com> wrote:
>
> +++ b/scripts/modules-check.sh
> @@ -0,0 +1,16 @@
> +#!/bin/sh
> +# SPDX-License-Identifier: GPL-2.0
> +
> +set -e
> +
> +# Check uniqueness of module names
> +check_same_name_modules()
> +{
> + for m in $(sed 's:.*/::' modules.order modules.builtin | sort | uniq -d)
> + do
> + echo "warning: same basename if the following are built as modules:" >&2
> + sed "/\/$m/!d;s:^kernel/: :" modules.order modules.builtin >&2
(bringing out my bike shed paint brush :-))
this could be
sed -n "/\/$m/s:^kernel/: :p" ...
--
Cheers,
Stephen Rothwell
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2019-05-20 0:04 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-17 16:07 Masahiro Yamada
2019-05-17 16:54 ` Masahiro Yamada
2019-05-19 7:16 ` Greg Kroah-Hartman
2019-05-19 23:51 ` Stephen Rothwell
2019-05-20 2:13 ` Masahiro Yamada
2019-05-20 3:59 ` Masahiro Yamada
2019-05-20 0:04 ` Stephen Rothwell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190520100437.54142214@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=alexander.kapshuk@gmail.com \
--cc=arnd@arndb.de \
--cc=bernd@petrovitsch.priv.at \
--cc=gregkh@linuxfoundation.org \
--cc=jeyu@kernel.org \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lucas.demarchi@intel.com \
--cc=michal.lkml@markovi.net \
--cc=rusty@rustcorp.com.au \
--cc=sam@ravnborg.org \
--cc=schmitzmic@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=yamada.masahiro@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®