From: Andrew Morton <akpm@linux-foundation.org>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpumask: Remove error message and backtrace on out-of-memory condition
Date: Tue, 28 May 2019 20:19:06 -0700 [thread overview]
Message-ID: <20190528201906.c0a5fb647b070c462bd7de1e@linux-foundation.org> (raw)
In-Reply-To: <20190527122958.6667-1-geert+renesas@glider.be>
On Mon, 27 May 2019 14:29:58 +0200 Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> There is no need to print an error message and backtrace if
> kmalloc_node() fails, as the memory allocation core already takes care
> of that.
>
> ...
>
> --- a/lib/cpumask.c
> +++ b/lib/cpumask.c
> @@ -114,13 +114,6 @@ bool alloc_cpumask_var_node(cpumask_var_t *mask, gfp_t flags, int node)
> {
> *mask = kmalloc_node(cpumask_size(), flags, node);
>
> -#ifdef CONFIG_DEBUG_PER_CPU_MAPS
> - if (!*mask) {
> - printk(KERN_ERR "=> alloc_cpumask_var: failed!\n");
> - dump_stack();
> - }
> -#endif
> -
> return *mask != NULL;
> }
> EXPORT_SYMBOL(alloc_cpumask_var_node);
Well, not really - as it stands CONFIG_DEBUG_PER_CPU_MAPS=y can override a
caller's __GFP_NOWARN.
I wonder if anyone ever sets CONFIG_DEBUG_PER_CPU_MAPS any more...
prev parent reply other threads:[~2019-05-29 3:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-27 12:29 Geert Uytterhoeven
2019-05-29 3:19 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190528201906.c0a5fb647b070c462bd7de1e@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®