* [PATCH] cpumask: Remove error message and backtrace on out-of-memory condition
@ 2019-05-27 12:29 Geert Uytterhoeven
2019-05-29 3:19 ` Andrew Morton
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-05-27 12:29 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Geert Uytterhoeven
There is no need to print an error message and backtrace if
kmalloc_node() fails, as the memory allocation core already takes care
of that.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
lib/cpumask.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/lib/cpumask.c b/lib/cpumask.c
index 0cb672eb107cef6e..61d85343dd50e61d 100644
--- a/lib/cpumask.c
+++ b/lib/cpumask.c
@@ -114,13 +114,6 @@ bool alloc_cpumask_var_node(cpumask_var_t *mask, gfp_t flags, int node)
{
*mask = kmalloc_node(cpumask_size(), flags, node);
-#ifdef CONFIG_DEBUG_PER_CPU_MAPS
- if (!*mask) {
- printk(KERN_ERR "=> alloc_cpumask_var: failed!\n");
- dump_stack();
- }
-#endif
-
return *mask != NULL;
}
EXPORT_SYMBOL(alloc_cpumask_var_node);
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] cpumask: Remove error message and backtrace on out-of-memory condition
2019-05-27 12:29 [PATCH] cpumask: Remove error message and backtrace on out-of-memory condition Geert Uytterhoeven
@ 2019-05-29 3:19 ` Andrew Morton
0 siblings, 0 replies; 2+ messages in thread
From: Andrew Morton @ 2019-05-29 3:19 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-kernel
On Mon, 27 May 2019 14:29:58 +0200 Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> There is no need to print an error message and backtrace if
> kmalloc_node() fails, as the memory allocation core already takes care
> of that.
>
> ...
>
> --- a/lib/cpumask.c
> +++ b/lib/cpumask.c
> @@ -114,13 +114,6 @@ bool alloc_cpumask_var_node(cpumask_var_t *mask, gfp_t flags, int node)
> {
> *mask = kmalloc_node(cpumask_size(), flags, node);
>
> -#ifdef CONFIG_DEBUG_PER_CPU_MAPS
> - if (!*mask) {
> - printk(KERN_ERR "=> alloc_cpumask_var: failed!\n");
> - dump_stack();
> - }
> -#endif
> -
> return *mask != NULL;
> }
> EXPORT_SYMBOL(alloc_cpumask_var_node);
Well, not really - as it stands CONFIG_DEBUG_PER_CPU_MAPS=y can override a
caller's __GFP_NOWARN.
I wonder if anyone ever sets CONFIG_DEBUG_PER_CPU_MAPS any more...
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-29 3:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-27 12:29 [PATCH] cpumask: Remove error message and backtrace on out-of-memory condition Geert Uytterhoeven
2019-05-29 3:19 ` Andrew Morton
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®