* [PATCH][next] drm/i915: fix use of uninitialized pointer vaddr
@ 2019-05-31 10:32 Colin King
2019-05-31 10:40 ` Chris Wilson
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2019-05-31 10:32 UTC (permalink / raw)
To: Matthew Auld, Jani Nikula, Joonas Lahtinen, Rodrigo Vivi,
David Airlie, Daniel Vetter, Chris Wilson, intel-gfx, dri-devel
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
The assignment of err is using the incorrect pointer vaddr that has
not been initialized. Fix this by using the correct pointer obj instead.
Addresses-Coverity: ("Uninitialized pointer read")
Fixes: 6501aa4e3a45 ("drm/i915: add in-kernel blitter client")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
index 8de568d2c792..e23d8c9e9298 100644
--- a/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
+++ b/drivers/gpu/drm/i915/gem/selftests/i915_gem_object_blt.c
@@ -32,7 +32,7 @@ static int igt_fill_blt(void *arg)
obj = i915_gem_object_create_internal(i915, sz);
if (IS_ERR(obj)) {
- err = PTR_ERR(vaddr);
+ err = PTR_ERR(obj);
goto err_flush;
}
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH][next] drm/i915: fix use of uninitialized pointer vaddr
2019-05-31 10:32 [PATCH][next] drm/i915: fix use of uninitialized pointer vaddr Colin King
@ 2019-05-31 10:40 ` Chris Wilson
0 siblings, 0 replies; 2+ messages in thread
From: Chris Wilson @ 2019-05-31 10:40 UTC (permalink / raw)
To: Colin King, Daniel Vetter, David Airlie, Jani Nikula,
Joonas Lahtinen, Matthew Auld, Rodrigo Vivi, dri-devel,
intel-gfx
Cc: kernel-janitors, linux-kernel
Quoting Colin King (2019-05-31 11:32:01)
> From: Colin Ian King <colin.king@canonical.com>
>
> The assignment of err is using the incorrect pointer vaddr that has
> not been initialized. Fix this by using the correct pointer obj instead.
>
> Addresses-Coverity: ("Uninitialized pointer read")
> Fixes: 6501aa4e3a45 ("drm/i915: add in-kernel blitter client")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
Reviewed and pushed, thanks for the fix!
-Chris
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-05-31 10:40 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-31 10:32 [PATCH][next] drm/i915: fix use of uninitialized pointer vaddr Colin King
2019-05-31 10:40 ` Chris Wilson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®