* [PATCH] drm/komeda: Avoid using DRIVER_IRQ_SHARED
@ 2019-06-07 10:46 Ayan Halder
0 siblings, 0 replies; only message in thread
From: Ayan Halder @ 2019-06-07 10:46 UTC (permalink / raw)
To: Ayan Halder, james qian wang (Arm Technology China),
Liviu Dudau, Brian Starkey, daniel, airlied, dri-devel,
linux-kernel
Cc: nd
With reference to mainline commit (1ff494813bafa127ecba1160262ba39b2fdde7ba),
DRIVER_IRQ_SHARED is to be used only by legacy drivers. Further,
drm_irq_install() ignores this flag altogether.
One needs to use devm_request_irq() instead, with IRQF_SHARED to create a shared
interrupt handler.
Signed-off-by: Ayan Kumar halder <ayan.halder@arm.com>
---
drivers/gpu/drm/arm/display/komeda/komeda_kms.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
index 86f6542afb40..7b5cde14e3ba 100644
--- a/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
+++ b/drivers/gpu/drm/arm/display/komeda/komeda_kms.c
@@ -194,7 +194,9 @@ struct komeda_kms_dev *komeda_kms_attach(struct komeda_dev *mdev)
drm_mode_config_reset(drm);
- err = drm_irq_install(drm, mdev->irq);
+ err = devm_request_irq(drm->dev, mdev->irq,
+ komeda_kms_driver.irq_handler, IRQF_SHARED,
+ drm->driver->name, drm);
if (err)
goto cleanup_mode_config;
--
2.21.0
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2019-06-07 10:47 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-07 10:46 [PATCH] drm/komeda: Avoid using DRIVER_IRQ_SHARED Ayan Halder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome