mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: xabi1500@gmail.com
Cc: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: rts5208: fixed brace coding style issue
Date: Sat, 8 Jun 2019 17:54:22 +0200	[thread overview]
Message-ID: <20190608155422.GB7974@kroah.com> (raw)
In-Reply-To: <20190608135335.6383-1-xabi1500@gmail.com>

On Sat, Jun 08, 2019 at 03:53:35PM +0200, xabi1500@gmail.com wrote:
> From: Xabier Etxezarreta <xabi1500@gmail.com>
> 
> Fixed a coding style issue checked with checkpatch.pl
> 
> Signed-off-by: Xabier Etxezarreta <xabi1500@gmail.com>
> ---
>  drivers/staging/rts5208/rtsx.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index fa597953e9a0..d16e92b09a1f 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -419,10 +419,7 @@ static int rtsx_control_thread(void *__dev)
>  				chip->srb->device->id,
>  				(u8)chip->srb->device->lun);
>  			chip->srb->result = DID_BAD_TARGET << 16;
> -		}
> -
> -		/* we've got a command, let's do it! */
> -		else {
> +		} else { /* we've got a command, let's do it! */
>  			scsi_show_command(chip);

Comment should go on a new line.

thanks,

greg k-h

      reply	other threads:[~2019-06-08 15:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-08 13:53 xabi1500
2019-06-08 15:54 ` Greg KH [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190608155422.GB7974@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=xabi1500@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®