* [PATCH] Staging: rts5208: fixed brace coding style issue
@ 2019-06-08 13:53 xabi1500
2019-06-08 15:54 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: xabi1500 @ 2019-06-08 13:53 UTC (permalink / raw)
To: gregkh; +Cc: devel, linux-kernel, Xabier Etxezarreta
From: Xabier Etxezarreta <xabi1500@gmail.com>
Fixed a coding style issue checked with checkpatch.pl
Signed-off-by: Xabier Etxezarreta <xabi1500@gmail.com>
---
drivers/staging/rts5208/rtsx.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
index fa597953e9a0..d16e92b09a1f 100644
--- a/drivers/staging/rts5208/rtsx.c
+++ b/drivers/staging/rts5208/rtsx.c
@@ -419,10 +419,7 @@ static int rtsx_control_thread(void *__dev)
chip->srb->device->id,
(u8)chip->srb->device->lun);
chip->srb->result = DID_BAD_TARGET << 16;
- }
-
- /* we've got a command, let's do it! */
- else {
+ } else { /* we've got a command, let's do it! */
scsi_show_command(chip);
rtsx_invoke_transport(chip->srb, chip);
}
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Staging: rts5208: fixed brace coding style issue
2019-06-08 13:53 [PATCH] Staging: rts5208: fixed brace coding style issue xabi1500
@ 2019-06-08 15:54 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2019-06-08 15:54 UTC (permalink / raw)
To: xabi1500; +Cc: devel, linux-kernel
On Sat, Jun 08, 2019 at 03:53:35PM +0200, xabi1500@gmail.com wrote:
> From: Xabier Etxezarreta <xabi1500@gmail.com>
>
> Fixed a coding style issue checked with checkpatch.pl
>
> Signed-off-by: Xabier Etxezarreta <xabi1500@gmail.com>
> ---
> drivers/staging/rts5208/rtsx.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/staging/rts5208/rtsx.c b/drivers/staging/rts5208/rtsx.c
> index fa597953e9a0..d16e92b09a1f 100644
> --- a/drivers/staging/rts5208/rtsx.c
> +++ b/drivers/staging/rts5208/rtsx.c
> @@ -419,10 +419,7 @@ static int rtsx_control_thread(void *__dev)
> chip->srb->device->id,
> (u8)chip->srb->device->lun);
> chip->srb->result = DID_BAD_TARGET << 16;
> - }
> -
> - /* we've got a command, let's do it! */
> - else {
> + } else { /* we've got a command, let's do it! */
> scsi_show_command(chip);
Comment should go on a new line.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-06-08 15:54 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-08 13:53 [PATCH] Staging: rts5208: fixed brace coding style issue xabi1500
2019-06-08 15:54 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®