From: Wei Li <liwei391@huawei.com>
To: <mark.rutland@arm.com>, <marc.zyngier@arm.com>,
<daniel.lezcano@linaro.org>, <tglx@linutronix.de>
Cc: <huawei.libin@huawei.com>, <linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: [PATCH] clocksource/arm_arch_timer: mark arch_timer_read_counter() as notrace to avoid deadloop
Date: Tue, 11 Jun 2019 23:21:35 +0800 [thread overview]
Message-ID: <20190611152135.44589-1-liwei391@huawei.com> (raw)
According to arch_counter_register(), mark arch_counter_get_*() what
arch_timer_read_counter() can be as notrace to avoid deadloop when using
function_graph tracer.
0xffff80028af23250 0xffff000010195e00 sched_clock+64
0xffff80028af23290 0xffff0000101e83ec trace_clock_local+12
0xffff80028af232a0 0xffff00001020e52c function_graph_enter+116
0xffff80028af23300 0xffff00001009af9c prepare_ftrace_return+44
0xffff80028af23320 0xffff00001009b0a8 ftrace_graph_caller+28
0xffff80028af23330 0xffff000010b01918 arch_counter_get_cntvct+16
0xffff80028af23340 0xffff000010195e00 sched_clock+64
0xffff80028af23380 0xffff0000101e83ec trace_clock_local+12
0xffff80028af23390 0xffff00001020e52c function_graph_enter+116
0xffff80028af233f0 0xffff00001009af9c prepare_ftrace_return+44
0xffff80028af23410 0xffff00001009b0a8 ftrace_graph_caller+28
0xffff80028af23420 0xffff000010b01918 arch_counter_get_cntvct+16
...
Fixes: 0ea415390cd3 ("clocksource/arm_arch_timer: Use arch_timer_read_counter to access stable counters")
Signed-off-by: Wei Li <liwei391@huawei.com>
---
drivers/clocksource/arm_arch_timer.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/clocksource/arm_arch_timer.c b/drivers/clocksource/arm_arch_timer.c
index b2a951a798e2..f4d5bd8fe906 100644
--- a/drivers/clocksource/arm_arch_timer.c
+++ b/drivers/clocksource/arm_arch_timer.c
@@ -149,22 +149,22 @@ u32 arch_timer_reg_read(int access, enum arch_timer_reg reg,
return val;
}
-static u64 arch_counter_get_cntpct_stable(void)
+static u64 notrace arch_counter_get_cntpct_stable(void)
{
return __arch_counter_get_cntpct_stable();
}
-static u64 arch_counter_get_cntpct(void)
+static u64 notrace arch_counter_get_cntpct(void)
{
return __arch_counter_get_cntpct();
}
-static u64 arch_counter_get_cntvct_stable(void)
+static u64 notrace arch_counter_get_cntvct_stable(void)
{
return __arch_counter_get_cntvct_stable();
}
-static u64 arch_counter_get_cntvct(void)
+static u64 notrace arch_counter_get_cntvct(void)
{
return __arch_counter_get_cntvct();
}
@@ -947,7 +947,7 @@ bool arch_timer_evtstrm_available(void)
return cpumask_test_cpu(raw_smp_processor_id(), &evtstrm_available);
}
-static u64 arch_counter_get_cntvct_mem(void)
+static u64 notrace arch_counter_get_cntvct_mem(void)
{
u32 vct_lo, vct_hi, tmp_hi;
--
2.17.1
next reply other threads:[~2019-06-11 15:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-11 15:21 Wei Li [this message]
2019-06-11 15:25 ` Marc Zyngier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190611152135.44589-1-liwei391@huawei.com \
--to=liwei391@huawei.com \
--cc=daniel.lezcano@linaro.org \
--cc=huawei.libin@huawei.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=mark.rutland@arm.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®