mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Marc Zyngier <marc.zyngier@arm.com>
To: Wei Li <liwei391@huawei.com>,
	mark.rutland@arm.com, daniel.lezcano@linaro.org,
	tglx@linutronix.de
Cc: huawei.libin@huawei.com, linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] clocksource/arm_arch_timer: mark arch_timer_read_counter() as notrace to avoid deadloop
Date: Tue, 11 Jun 2019 16:25:26 +0100	[thread overview]
Message-ID: <9a68f57b-98f4-c2ba-25cb-20ad745f6af5@arm.com> (raw)
In-Reply-To: <20190611152135.44589-1-liwei391@huawei.com>

Hi Wei,

On 11/06/2019 16:21, Wei Li wrote:
> According to arch_counter_register(), mark arch_counter_get_*() what
> arch_timer_read_counter() can be as notrace to avoid deadloop when using
> function_graph tracer.
> 
>  0xffff80028af23250 0xffff000010195e00 sched_clock+64
>  0xffff80028af23290 0xffff0000101e83ec trace_clock_local+12
>  0xffff80028af232a0 0xffff00001020e52c function_graph_enter+116
>  0xffff80028af23300 0xffff00001009af9c prepare_ftrace_return+44
>  0xffff80028af23320 0xffff00001009b0a8 ftrace_graph_caller+28
>  0xffff80028af23330 0xffff000010b01918 arch_counter_get_cntvct+16
>  0xffff80028af23340 0xffff000010195e00 sched_clock+64
>  0xffff80028af23380 0xffff0000101e83ec trace_clock_local+12
>  0xffff80028af23390 0xffff00001020e52c function_graph_enter+116
>  0xffff80028af233f0 0xffff00001009af9c prepare_ftrace_return+44
>  0xffff80028af23410 0xffff00001009b0a8 ftrace_graph_caller+28
>  0xffff80028af23420 0xffff000010b01918 arch_counter_get_cntvct+16
>  ...
> 
> Fixes: 0ea415390cd3 ("clocksource/arm_arch_timer: Use arch_timer_read_counter to access stable counters")
> Signed-off-by: Wei Li <liwei391@huawei.com>

There is already a patch[1] queued for that. Hopefully Daniel
and Thomas will get this into mainline shortly.

Thanks,

	M.

[1] https://lore.kernel.org/lkml/20190524093600.11ca3cb2@gandalf.local.home/T/
-- 
Jazz is not dead. It just smells funny...

      reply	other threads:[~2019-06-11 15:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-11 15:21 Wei Li
2019-06-11 15:25 ` Marc Zyngier [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9a68f57b-98f4-c2ba-25cb-20ad745f6af5@arm.com \
    --to=marc.zyngier@arm.com \
    --cc=daniel.lezcano@linaro.org \
    --cc=huawei.libin@huawei.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liwei391@huawei.com \
    --cc=mark.rutland@arm.com \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®