mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Gen Zhang <blackgod016574@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: nico@fluxnic.net, kilobyte@angband.pl, textshell@uchuujin.de,
	mpatocka@redhat.com, daniel.vetter@ffwll.ch,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] vt: fix a missing-check bug in con_init()
Date: Wed, 12 Jun 2019 21:44:49 +0800	[thread overview]
Message-ID: <20190612134449.GA4015@zhanggen-UX430UQ> (raw)
In-Reply-To: <20190612133838.GA7748@kroah.com>

On Wed, Jun 12, 2019 at 03:38:38PM +0200, Greg KH wrote:
> On Wed, Jun 12, 2019 at 09:15:06PM +0800, Gen Zhang wrote:
> > In function con_init(), the pointer variable vc_cons[currcons].d, vc and 
> > vc->vc_screenbuf is allocated by kzalloc(). However, kzalloc() returns 
> > NULL when fails. Therefore, we should check the return value and handle 
> > the error.
> > 
> > Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
> > ---
> 
> What changed from v1, v2, and v3?
Thanks for your timely response. I am not a native English speaker, so
I am not sure I understand this correctly. Does this mean that I should
use "v5", rather than "v4"? 
> 
> That always goes below the --- line.
And I can't see what goes wrong with "---". Could you please make some
explaination?

Thanks
Gen
> 
> v5 please.
> 
> thanks,
> 
> greg k-h

  reply	other threads:[~2019-06-12 13:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-12 13:15 Gen Zhang
2019-06-12 13:38 ` Greg KH
2019-06-12 13:44   ` Gen Zhang [this message]
2019-06-12 14:23     ` Greg KH
2019-06-12 14:32     ` Nicolas Pitre

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190612134449.GA4015@zhanggen-UX430UQ \
    --to=blackgod016574@gmail.com \
    --cc=daniel.vetter@ffwll.ch \
    --cc=gregkh@linuxfoundation.org \
    --cc=kilobyte@angband.pl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mpatocka@redhat.com \
    --cc=nico@fluxnic.net \
    --cc=textshell@uchuujin.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®