From: Greg KH <gregkh@linuxfoundation.org>
To: Gen Zhang <blackgod016574@gmail.com>
Cc: nico@fluxnic.net, kilobyte@angband.pl, textshell@uchuujin.de,
mpatocka@redhat.com, daniel.vetter@ffwll.ch,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] vt: fix a missing-check bug in con_init()
Date: Wed, 12 Jun 2019 15:38:38 +0200 [thread overview]
Message-ID: <20190612133838.GA7748@kroah.com> (raw)
In-Reply-To: <20190612131506.GA3526@zhanggen-UX430UQ>
On Wed, Jun 12, 2019 at 09:15:06PM +0800, Gen Zhang wrote:
> In function con_init(), the pointer variable vc_cons[currcons].d, vc and
> vc->vc_screenbuf is allocated by kzalloc(). However, kzalloc() returns
> NULL when fails. Therefore, we should check the return value and handle
> the error.
>
> Signed-off-by: Gen Zhang <blackgod016574@gmail.com>
> ---
What changed from v1, v2, and v3?
That always goes below the --- line.
v5 please.
thanks,
greg k-h
next prev parent reply other threads:[~2019-06-12 13:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-12 13:15 Gen Zhang
2019-06-12 13:38 ` Greg KH [this message]
2019-06-12 13:44 ` Gen Zhang
2019-06-12 14:23 ` Greg KH
2019-06-12 14:32 ` Nicolas Pitre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190612133838.GA7748@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=blackgod016574@gmail.com \
--cc=daniel.vetter@ffwll.ch \
--cc=kilobyte@angband.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=nico@fluxnic.net \
--cc=textshell@uchuujin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®