From: Anisse Astier <aastier@freebox.fr>
To: Will Deacon <will.deacon@arm.com>,
Dave Martin <Dave.Martin@arm.com>,
linux-arm-kernel@lists.infradead.org
Cc: Catalin Marinas <catalin.marinas@arm.com>,
Kristina Martsenko <kristina.martsenko@arm.com>,
Richard Henderson <richard.henderson@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, Rich Felker <dalias@aerifal.cx>,
"Dmitry V . Levin" <ldv@altlinux.org>,
Ricardo Salveti <ricardo@foundries.io>,
Sasha Levin <sashal@kernel.org>,
Anisse Astier <aastier@freebox.fr>
Subject: [PATCH v3 1/2] arm64: ssbd: explicitly depend on <linux/prctl.h>
Date: Mon, 17 Jun 2019 15:22:21 +0200 [thread overview]
Message-ID: <20190617132222.32182-1-aastier@freebox.fr> (raw)
In-Reply-To: <20190617084545.GA38959@anisse-station>
Fix ssbd.c which depends implicitly on asm/ptrace.h including
linux/prctl.h (through for example linux/compat.h, then linux/time.h,
linux/seqlock.h, linux/spinlock.h and linux/irqflags.h), and uses
PR_SPEC* defines.
This is an issue since we'll remove the include in the next commit.
Fixes: 9cdc0108baa8 ("arm64: ssbd: Add prctl interface for per-thread mitigation")
Cc: stable@vger.kernel.org
Signed-off-by: Anisse Astier <aastier@freebox.fr>
---
Contrary to what I said in the previous email, I can reproduce the build
error on Linus' master when ARM64_SSBD is enabled.
Changes since v2:
- fix build when ARM64_SSBD is enabled with additionnal patch
Changes since v1:
- made a bit more explicit that we copied defined symbols, in commit
and code.
- Use Fixes: tag in commit message
Thanks to Dave Martin and Will Deacon for the review, and Sasha Levin
for the auto-build bot.
---
arch/arm64/kernel/ssbd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/kernel/ssbd.c b/arch/arm64/kernel/ssbd.c
index 885f13e58708..52cfc6148355 100644
--- a/arch/arm64/kernel/ssbd.c
+++ b/arch/arm64/kernel/ssbd.c
@@ -5,6 +5,7 @@
#include <linux/compat.h>
#include <linux/errno.h>
+#include <linux/prctl.h>
#include <linux/sched.h>
#include <linux/sched/task_stack.h>
#include <linux/thread_info.h>
--
2.19.1
next parent reply other threads:[~2019-06-17 13:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190617084545.GA38959@anisse-station>
2019-06-17 13:22 ` Anisse Astier [this message]
2019-06-17 13:22 ` [PATCH v3 2/2] arm64/sve: <uapi/asm/ptrace.h> should not depend on <uapi/linux/prctl.h> Anisse Astier
2019-06-18 13:50 ` Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190617132222.32182-1-aastier@freebox.fr \
--to=aastier@freebox.fr \
--cc=Dave.Martin@arm.com \
--cc=catalin.marinas@arm.com \
--cc=dalias@aerifal.cx \
--cc=kristina.martsenko@arm.com \
--cc=ldv@altlinux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ricardo@foundries.io \
--cc=richard.henderson@linaro.org \
--cc=sashal@kernel.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®