From: Will Deacon <will.deacon@arm.com>
To: Anisse Astier <aastier@freebox.fr>
Cc: Dave Martin <Dave.Martin@arm.com>,
linux-arm-kernel@lists.infradead.org,
Catalin Marinas <catalin.marinas@arm.com>,
Kristina Martsenko <kristina.martsenko@arm.com>,
Richard Henderson <richard.henderson@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-kernel@vger.kernel.org, Rich Felker <dalias@aerifal.cx>,
"Dmitry V . Levin" <ldv@altlinux.org>,
Ricardo Salveti <ricardo@foundries.io>,
Sasha Levin <sashal@kernel.org>
Subject: Re: [PATCH v3 2/2] arm64/sve: <uapi/asm/ptrace.h> should not depend on <uapi/linux/prctl.h>
Date: Tue, 18 Jun 2019 14:50:46 +0100 [thread overview]
Message-ID: <20190618135046.GH31041@fuggles.cambridge.arm.com> (raw)
In-Reply-To: <20190617132222.32182-2-aastier@freebox.fr>
On Mon, Jun 17, 2019 at 03:22:22PM +0200, Anisse Astier wrote:
> Otherwise this will create userspace build issues for any program
> (strace, qemu) that includes both <sys/prctl.h> (with musl libc) and
> <linux/ptrace.h> (which then includes <asm/ptrace.h>), like this:
>
> error: redefinition of 'struct prctl_mm_map'
> struct prctl_mm_map {
>
> See https://github.com/foundriesio/meta-lmp/commit/6d4a106e191b5d79c41b9ac78fd321316d3013c0
> for a public example of people working around this issue.
>
> Copying the defines is a bit imperfect here, but better than creating a
> whole other header for just two defines that would never change, as part
> of the kernel ABI.
>
> This patch depends on patch "arm64: ssbd: explicitly depend on
> <linux/prctl.h>" for kernel >= 4.18
>
> Fixes: 43d4da2c45b2 ("arm64/sve: ptrace and ELF coredump support")
> Cc: stable@vger.kernel.org
> Signed-off-by: Anisse Astier <aastier@freebox.fr>
> ---
> arch/arm64/include/uapi/asm/ptrace.h | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
I've pushed these two out to the arm64 fixes branch [1], with Dave's Ack
on this one. Note that I reworked the commit messages a bit to explain
better what's going on.
Cheers,
Will
[1] https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=for-next/fixes
prev parent reply other threads:[~2019-06-18 13:50 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190617084545.GA38959@anisse-station>
2019-06-17 13:22 ` [PATCH v3 1/2] arm64: ssbd: explicitly depend on <linux/prctl.h> Anisse Astier
2019-06-17 13:22 ` [PATCH v3 2/2] arm64/sve: <uapi/asm/ptrace.h> should not depend on <uapi/linux/prctl.h> Anisse Astier
2019-06-18 13:50 ` Will Deacon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190618135046.GH31041@fuggles.cambridge.arm.com \
--to=will.deacon@arm.com \
--cc=Dave.Martin@arm.com \
--cc=aastier@freebox.fr \
--cc=catalin.marinas@arm.com \
--cc=dalias@aerifal.cx \
--cc=kristina.martsenko@arm.com \
--cc=ldv@altlinux.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=ricardo@foundries.io \
--cc=richard.henderson@linaro.org \
--cc=sashal@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®