mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: kbuild test robot <lkp@intel.com>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: kbuild-all@01.org, Ezequiel Garcia <ezequiel@collabora.com>,
	Nick Crews <ncrews@chromium.org>,
	Benson Leung <bleung@chromium.org>,
	linux-kernel@vger.kernel.org
Subject: [PATCH] platform/chrome: cros_ec_lpc: fix stream_open.cocci warnings
Date: Sat, 22 Jun 2019 08:55:47 +0800	[thread overview]
Message-ID: <20190622005547.GA65190@lkp-kbuild08> (raw)
In-Reply-To: <201906220821.144PfQAY%lkp@intel.com>

From: kbuild test robot <lkp@intel.com>

drivers/platform/chrome/wilco_ec/event.c:270:1-17: WARNING: event_fops: .read() has stream semantic; safe to change nonseekable_open -> stream_open.

Generated by: scripts/coccinelle/api/stream_open.cocci

Fixes: 22c040fa21b6 ("platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime")
Signed-off-by: kbuild test robot <lkp@intel.com>
---

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/chrome-platform/linux.git for-next
head:   9eecd07b34507de9d6a9c264d13d30e1ee5fabe8
commit: 22c040fa21b604b9b3d88645e108fb2f0a74474b [21/22] platform/chrome: cros_ec_lpc: Choose Microchip EC at runtime

Please take the patch only if it's a positive warning. Thanks!

 event.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- a/drivers/platform/chrome/wilco_ec/event.c
+++ b/drivers/platform/chrome/wilco_ec/event.c
@@ -267,7 +267,7 @@ static int event_open(struct inode *inod
 
 	/* Increase refcount on device so dev_data is not freed */
 	get_device(&dev_data->dev);
-	nonseekable_open(inode, filp);
+	stream_open(inode, filp);
 	filp->private_data = dev_data;
 
 	return 0;

       reply	other threads:[~2019-06-22  0:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <201906220821.144PfQAY%lkp@intel.com>
2019-06-22  0:55 ` kbuild test robot [this message]
2019-06-24 15:18   ` Nick Crews
2019-06-22  0:55 ` [PATCH] platform/chrome: cros_ec_lpc: fix semicolon.cocci warnings kbuild test robot
2019-06-24 15:14   ` Nick Crews

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190622005547.GA65190@lkp-kbuild08 \
    --to=lkp@intel.com \
    --cc=bleung@chromium.org \
    --cc=enric.balletbo@collabora.com \
    --cc=ezequiel@collabora.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=ncrews@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®