* [PATCH] mwifiex: drop 'set_consistent_dma_mask' log message
@ 2019-06-04 17:28 Brian Norris
2019-06-25 4:46 ` Kalle Valo
0 siblings, 1 reply; 4+ messages in thread
From: Brian Norris @ 2019-06-04 17:28 UTC (permalink / raw)
To: Ganapathi Bhat, Nishant Sarmukadam, Amitkumar Karwar, Xinming Hu
Cc: linux-kernel, linux-wireless, Brian Norris
This message is pointless.
While we're at it, include the error code in the error message, which is
not pointless.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
drivers/net/wireless/marvell/mwifiex/pcie.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c
index 3fe81b2a929a..82f58bf0fc43 100644
--- a/drivers/net/wireless/marvell/mwifiex/pcie.c
+++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
@@ -2924,10 +2924,9 @@ static int mwifiex_init_pcie(struct mwifiex_adapter *adapter)
pci_set_master(pdev);
- pr_notice("try set_consistent_dma_mask(32)\n");
ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
if (ret) {
- pr_err("set_dma_mask(32) failed\n");
+ pr_err("set_dma_mask(32) failed: %d\n", ret);
goto err_set_dma_mask;
}
--
2.22.0.rc1.311.g5d7573a151-goog
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mwifiex: drop 'set_consistent_dma_mask' log message
2019-06-04 17:28 [PATCH] mwifiex: drop 'set_consistent_dma_mask' log message Brian Norris
@ 2019-06-25 4:46 ` Kalle Valo
0 siblings, 0 replies; 4+ messages in thread
From: Kalle Valo @ 2019-06-25 4:46 UTC (permalink / raw)
To: Brian Norris
Cc: Ganapathi Bhat, Nishant Sarmukadam, Amitkumar Karwar, Xinming Hu,
linux-kernel, linux-wireless, Brian Norris
Brian Norris <briannorris@chromium.org> wrote:
> This message is pointless.
>
> While we're at it, include the error code in the error message, which is
> not pointless.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Patch applied to wireless-drivers-next.git, thanks.
f7369179ad32 mwifiex: drop 'set_consistent_dma_mask' log message
--
https://patchwork.kernel.org/patch/10975823/
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] mwifiex: drop 'set_consistent_dma_mask' log message
@ 2019-06-04 17:29 Brian Norris
2019-06-04 17:31 ` Brian Norris
0 siblings, 1 reply; 4+ messages in thread
From: Brian Norris @ 2019-06-04 17:29 UTC (permalink / raw)
To: Ganapathi Bhat, Nishant Sarmukadam, Amitkumar Karwar, Xinming Hu
Cc: linux-kernel, linux-wireless, Brian Norris
This message is pointless.
While we're at it, include the error code in the error message, which is
not pointless.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
drivers/net/wireless/marvell/mwifiex/pcie.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/pcie.c b/drivers/net/wireless/marvell/mwifiex/pcie.c
index 3fe81b2a929a..82f58bf0fc43 100644
--- a/drivers/net/wireless/marvell/mwifiex/pcie.c
+++ b/drivers/net/wireless/marvell/mwifiex/pcie.c
@@ -2924,10 +2924,9 @@ static int mwifiex_init_pcie(struct mwifiex_adapter *adapter)
pci_set_master(pdev);
- pr_notice("try set_consistent_dma_mask(32)\n");
ret = pci_set_dma_mask(pdev, DMA_BIT_MASK(32));
if (ret) {
- pr_err("set_dma_mask(32) failed\n");
+ pr_err("set_dma_mask(32) failed: %d\n", ret);
goto err_set_dma_mask;
}
--
2.22.0.rc1.311.g5d7573a151-goog
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mwifiex: drop 'set_consistent_dma_mask' log message
2019-06-04 17:29 Brian Norris
@ 2019-06-04 17:31 ` Brian Norris
0 siblings, 0 replies; 4+ messages in thread
From: Brian Norris @ 2019-06-04 17:31 UTC (permalink / raw)
To: Ganapathi Bhat, Nishant Sarmukadam, Amitkumar Karwar, Xinming Hu
Cc: Linux Kernel, linux-wireless
On Tue, Jun 4, 2019 at 10:29 AM Brian Norris <briannorris@chromium.org> wrote:
>
> This message is pointless.
>
> While we're at it, include the error code in the error message, which is
> not pointless.
>
> Signed-off-by: Brian Norris <briannorris@chromium.org>
Oops, I sent this patch twice. Sorry!
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-25 4:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-04 17:28 [PATCH] mwifiex: drop 'set_consistent_dma_mask' log message Brian Norris
2019-06-25 4:46 ` Kalle Valo
2019-06-04 17:29 Brian Norris
2019-06-04 17:31 ` Brian Norris
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome