* [PATCH 07/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone
@ 2019-06-29 10:27 Hariprasad Kelam
2019-06-29 10:40 ` Hariprasad Kelam
0 siblings, 1 reply; 3+ messages in thread
From: Hariprasad Kelam @ 2019-06-29 10:27 UTC (permalink / raw)
To: Greg Kroah-Hartman, Hariprasad Kelam, devel, linux-kernel
fix below issues reported by checkpatch
CHECK: Using comparison to false is error prone
CHECK: Using comparison to true is error prone
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
index a733046..7883b26 100644
--- a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
+++ b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
@@ -221,7 +221,7 @@ void ODM_CfoTracking(void *pDM_VOID)
pCfoTrack->CFO_ave_pre = CFO_ave;
/* 4 1.4 Dynamic Xtal threshold */
- if (pCfoTrack->bAdjust == false) {
+ if (!pCfoTrack->bAdjust) {
if (CFO_ave > CFO_TH_XTAL_HIGH || CFO_ave < (-CFO_TH_XTAL_HIGH))
pCfoTrack->bAdjust = true;
} else {
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 07/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone
2019-06-29 10:27 [PATCH 07/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone Hariprasad Kelam
@ 2019-06-29 10:40 ` Hariprasad Kelam
0 siblings, 0 replies; 3+ messages in thread
From: Hariprasad Kelam @ 2019-06-29 10:40 UTC (permalink / raw)
To: Greg Kroah-Hartman, devel, linux-kernel
On Sat, Jun 29, 2019 at 03:57:22PM +0530, Hariprasad Kelam wrote:
Please ignore this patch
> fix below issues reported by checkpatch
>
> CHECK: Using comparison to false is error prone
> CHECK: Using comparison to true is error prone
>
> Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
> ---
> drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
> index a733046..7883b26 100644
> --- a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
> +++ b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
> @@ -221,7 +221,7 @@ void ODM_CfoTracking(void *pDM_VOID)
> pCfoTrack->CFO_ave_pre = CFO_ave;
>
> /* 4 1.4 Dynamic Xtal threshold */
> - if (pCfoTrack->bAdjust == false) {
> + if (!pCfoTrack->bAdjust) {
> if (CFO_ave > CFO_TH_XTAL_HIGH || CFO_ave < (-CFO_TH_XTAL_HIGH))
> pCfoTrack->bAdjust = true;
> } else {
> --
> 2.7.4
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 07/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone
@ 2019-06-29 10:26 Hariprasad Kelam
0 siblings, 0 replies; 3+ messages in thread
From: Hariprasad Kelam @ 2019-06-29 10:26 UTC (permalink / raw)
To: Greg Kroah-Hartman, Hariprasad Kelam, devel, linux-kernel
fix below issues reported by checkpatch
CHECK: Using comparison to false is error prone
CHECK: Using comparison to true is error prone
Signed-off-by: Hariprasad Kelam <hariprasad.kelam@gmail.com>
---
drivers/staging/rtl8723bs/hal/odm_CfoTracking.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
index a733046..7883b26 100644
--- a/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
+++ b/drivers/staging/rtl8723bs/hal/odm_CfoTracking.c
@@ -221,7 +221,7 @@ void ODM_CfoTracking(void *pDM_VOID)
pCfoTrack->CFO_ave_pre = CFO_ave;
/* 4 1.4 Dynamic Xtal threshold */
- if (pCfoTrack->bAdjust == false) {
+ if (!pCfoTrack->bAdjust) {
if (CFO_ave > CFO_TH_XTAL_HIGH || CFO_ave < (-CFO_TH_XTAL_HIGH))
pCfoTrack->bAdjust = true;
} else {
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-06-29 10:40 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-29 10:27 [PATCH 07/10] staging/rtl8723bs/hal: fix comparison to true/false is error prone Hariprasad Kelam
2019-06-29 10:40 ` Hariprasad Kelam
-- strict thread matches above, loose matches on Subject: below --
2019-06-29 10:26 Hariprasad Kelam
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®