From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: blogic@openwrt.org, linus.walleij@linaro.org,
bgolaszewski@baylibre.com, linux-gpio@vger.kernel.org
Cc: dev@kresin.me, linux-kernel@vger.kernel.org,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Subject: [PATCH 3/4] gpio: stp-xway: get rid of the #include <lantiq_soc.h> dependency
Date: Wed, 3 Jul 2019 00:32:47 +0200 [thread overview]
Message-ID: <20190702223248.31934-4-martin.blumenstingl@googlemail.com> (raw)
In-Reply-To: <20190702223248.31934-1-martin.blumenstingl@googlemail.com>
Use the xway_stp_{r,w}32 helpers in xway_stp_w32_mask instead of relying
on ltq_{r,w}32 from the architecture specific <lantiq_soc.h>.
This will allow the driver to be compile-tested on all architectures
that support MMIO.
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/gpio/gpio-stp-xway.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/gpio/gpio-stp-xway.c b/drivers/gpio/gpio-stp-xway.c
index b31e08f84681..9e23a5ae8108 100644
--- a/drivers/gpio/gpio-stp-xway.c
+++ b/drivers/gpio/gpio-stp-xway.c
@@ -15,8 +15,6 @@
#include <linux/clk.h>
#include <linux/err.h>
-#include <lantiq_soc.h>
-
/*
* The Serial To Parallel (STP) is found on MIPS based Lantiq socs. It is a
* peripheral controller used to drive external shift register cascades. At most
@@ -71,8 +69,7 @@
#define xway_stp_r32(m, reg) __raw_readl(m + reg)
#define xway_stp_w32(m, val, reg) __raw_writel(val, m + reg)
#define xway_stp_w32_mask(m, clear, set, reg) \
- ltq_w32((ltq_r32(m + reg) & ~(clear)) | (set), \
- m + reg)
+ xway_stp_w32(m, (xway_stp_r32(m, reg) & ~(clear)) | (set), reg)
struct xway_stp {
struct gpio_chip gc;
--
2.22.0
next prev parent reply other threads:[~2019-07-03 0:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-02 22:32 [PATCH 0/4] gpio: stp-xway: small cleanups and improvements Martin Blumenstingl
2019-07-02 22:32 ` [PATCH 1/4] gpio: stp-xway: simplify error handling in xway_stp_probe() Martin Blumenstingl
2019-07-04 7:39 ` Linus Walleij
2019-07-02 22:32 ` [PATCH 2/4] gpio: stp-xway: improve module clock error handling Martin Blumenstingl
2019-07-04 7:40 ` Linus Walleij
2019-07-02 22:32 ` Martin Blumenstingl [this message]
2019-07-04 7:41 ` [PATCH 3/4] gpio: stp-xway: get rid of the #include <lantiq_soc.h> dependency Linus Walleij
2019-07-02 22:32 ` [PATCH 4/4] gpio: stp-xway: allow compile-testing Martin Blumenstingl
2019-07-04 7:44 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190702223248.31934-4-martin.blumenstingl@googlemail.com \
--to=martin.blumenstingl@googlemail.com \
--cc=bgolaszewski@baylibre.com \
--cc=blogic@openwrt.org \
--cc=dev@kresin.me \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®