* [PATCH] dma-mapping: mark dma_alloc_need_uncached as __always_inline
@ 2019-07-08 19:57 Christoph Hellwig
2019-07-08 21:14 ` Randy Dunlap
0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2019-07-08 19:57 UTC (permalink / raw)
To: rdunlap; +Cc: iommu, linux-kernel
Without the __always_inline at least i386 configs that have
CONFIG_OPTIMIZE_INLINING set seem fail to inline
dma_alloc_need_uncached, leading to a linker error because of
undefined symbols.
Reported-by: Randy Dunlap <rdunlap@infradead.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
include/linux/dma-noncoherent.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/linux/dma-noncoherent.h b/include/linux/dma-noncoherent.h
index 53ee36ecdf37..3813211a9aad 100644
--- a/include/linux/dma-noncoherent.h
+++ b/include/linux/dma-noncoherent.h
@@ -23,7 +23,7 @@ static inline bool dev_is_dma_coherent(struct device *dev)
/*
* Check if an allocation needs to be marked uncached to be coherent.
*/
-static inline bool dma_alloc_need_uncached(struct device *dev,
+static __always_inline bool dma_alloc_need_uncached(struct device *dev,
unsigned long attrs)
{
if (dev_is_dma_coherent(dev))
--
2.20.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] dma-mapping: mark dma_alloc_need_uncached as __always_inline
2019-07-08 19:57 [PATCH] dma-mapping: mark dma_alloc_need_uncached as __always_inline Christoph Hellwig
@ 2019-07-08 21:14 ` Randy Dunlap
0 siblings, 0 replies; 2+ messages in thread
From: Randy Dunlap @ 2019-07-08 21:14 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: iommu, linux-kernel
On 7/8/19 12:57 PM, Christoph Hellwig wrote:
> Without the __always_inline at least i386 configs that have
> CONFIG_OPTIMIZE_INLINING set seem fail to inline
> dma_alloc_need_uncached, leading to a linker error because of
> undefined symbols.
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Acked-by: Randy Dunlap <rdunlap@infradead.org> # build-tested
Thanks.
> ---
> include/linux/dma-noncoherent.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/dma-noncoherent.h b/include/linux/dma-noncoherent.h
> index 53ee36ecdf37..3813211a9aad 100644
> --- a/include/linux/dma-noncoherent.h
> +++ b/include/linux/dma-noncoherent.h
> @@ -23,7 +23,7 @@ static inline bool dev_is_dma_coherent(struct device *dev)
> /*
> * Check if an allocation needs to be marked uncached to be coherent.
> */
> -static inline bool dma_alloc_need_uncached(struct device *dev,
> +static __always_inline bool dma_alloc_need_uncached(struct device *dev,
> unsigned long attrs)
> {
> if (dev_is_dma_coherent(dev))
>
--
~Randy
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-08 21:14 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-08 19:57 [PATCH] dma-mapping: mark dma_alloc_need_uncached as __always_inline Christoph Hellwig
2019-07-08 21:14 ` Randy Dunlap
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®