* [PATCH] habanalabs: add debug print when rejecting CS
@ 2019-07-18 6:29 Oded Gabbay
2019-07-18 6:42 ` Omer Shpigelman
0 siblings, 1 reply; 2+ messages in thread
From: Oded Gabbay @ 2019-07-18 6:29 UTC (permalink / raw)
To: linux-kernel, oshpigelman, ttayar; +Cc: gregkh
When rejecting CS because of too many in-flight CS, print a debug message
about it as it useful to know when the user is debugging (it indicates a
back-pressure from the driver as the device is not fast enough to consume
the CS)
Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
---
drivers/misc/habanalabs/command_submission.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/misc/habanalabs/command_submission.c b/drivers/misc/habanalabs/command_submission.c
index 6ad83d5ef4b0..f4e2c2ad0057 100644
--- a/drivers/misc/habanalabs/command_submission.c
+++ b/drivers/misc/habanalabs/command_submission.c
@@ -305,6 +305,8 @@ static int allocate_cs(struct hl_device *hdev, struct hl_ctx *ctx,
other = ctx->cs_pending[fence->cs_seq & (HL_MAX_PENDING_CS - 1)];
if ((other) && (!dma_fence_is_signaled(other))) {
spin_unlock(&ctx->cs_lock);
+ dev_dbg(hdev->dev,
+ "Rejecting CS because of too many in-flights CS\n");
rc = -EAGAIN;
goto free_fence;
}
--
2.17.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* RE: [PATCH] habanalabs: add debug print when rejecting CS
2019-07-18 6:29 [PATCH] habanalabs: add debug print when rejecting CS Oded Gabbay
@ 2019-07-18 6:42 ` Omer Shpigelman
0 siblings, 0 replies; 2+ messages in thread
From: Omer Shpigelman @ 2019-07-18 6:42 UTC (permalink / raw)
To: Oded Gabbay, linux-kernel, Tomer Tayar; +Cc: gregkh
From: Oded Gabbay <oded.gabbay@gmail.com>
Sent: Thursday, 18 July 2019 9:30
> When rejecting CS because of too many in-flight CS, print a debug message
> about it as it useful to know when the user is debugging (it indicates a back-
> pressure from the driver as the device is not fast enough to consume the CS)
>
> Signed-off-by: Oded Gabbay <oded.gabbay@gmail.com>
Reviewed-by: Omer Shpigelman <oshpigelman@habana.ai>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-18 6:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18 6:29 [PATCH] habanalabs: add debug print when rejecting CS Oded Gabbay
2019-07-18 6:42 ` Omer Shpigelman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®