* [PATCH] crypto: ccp - Replace dma_pool_alloc + memset with dma_pool_zalloc
@ 2019-07-18 13:16 Chuhong Yuan
2019-07-18 21:50 ` Gary R Hook
2019-07-26 12:35 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Chuhong Yuan @ 2019-07-18 13:16 UTC (permalink / raw)
Cc: Tom Lendacky, Gary Hook, Herbert Xu, David S . Miller,
linux-crypto, linux-kernel, Chuhong Yuan
Use dma_pool_zalloc instead of using dma_pool_alloc to allocate
memory and then zeroing it with memset 0.
This simplifies the code.
Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
---
drivers/crypto/ccp/ccp-ops.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
index 866b2e05ca77..03797c42b336 100644
--- a/drivers/crypto/ccp/ccp-ops.c
+++ b/drivers/crypto/ccp/ccp-ops.c
@@ -150,14 +150,13 @@ static int ccp_init_dm_workarea(struct ccp_dm_workarea *wa,
if (len <= CCP_DMAPOOL_MAX_SIZE) {
wa->dma_pool = cmd_q->dma_pool;
- wa->address = dma_pool_alloc(wa->dma_pool, GFP_KERNEL,
+ wa->address = dma_pool_zalloc(wa->dma_pool, GFP_KERNEL,
&wa->dma.address);
if (!wa->address)
return -ENOMEM;
wa->dma.length = CCP_DMAPOOL_MAX_SIZE;
- memset(wa->address, 0, CCP_DMAPOOL_MAX_SIZE);
} else {
wa->address = kzalloc(len, GFP_KERNEL);
if (!wa->address)
--
2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: ccp - Replace dma_pool_alloc + memset with dma_pool_zalloc
2019-07-18 13:16 [PATCH] crypto: ccp - Replace dma_pool_alloc + memset with dma_pool_zalloc Chuhong Yuan
@ 2019-07-18 21:50 ` Gary R Hook
2019-07-26 12:35 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Gary R Hook @ 2019-07-18 21:50 UTC (permalink / raw)
To: Chuhong Yuan
Cc: Lendacky, Thomas, Hook, Gary, Herbert Xu, David S . Miller,
linux-crypto, linux-kernel
On 7/18/19 8:16 AM, Chuhong Yuan wrote:
> Use dma_pool_zalloc instead of using dma_pool_alloc to allocate
> memory and then zeroing it with memset 0.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
Acked-by: Gary R Hook <gary.hook@amd.com>
> ---
> drivers/crypto/ccp/ccp-ops.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/crypto/ccp/ccp-ops.c b/drivers/crypto/ccp/ccp-ops.c
> index 866b2e05ca77..03797c42b336 100644
> --- a/drivers/crypto/ccp/ccp-ops.c
> +++ b/drivers/crypto/ccp/ccp-ops.c
> @@ -150,14 +150,13 @@ static int ccp_init_dm_workarea(struct ccp_dm_workarea *wa,
> if (len <= CCP_DMAPOOL_MAX_SIZE) {
> wa->dma_pool = cmd_q->dma_pool;
>
> - wa->address = dma_pool_alloc(wa->dma_pool, GFP_KERNEL,
> + wa->address = dma_pool_zalloc(wa->dma_pool, GFP_KERNEL,
> &wa->dma.address);
> if (!wa->address)
> return -ENOMEM;
>
> wa->dma.length = CCP_DMAPOOL_MAX_SIZE;
>
> - memset(wa->address, 0, CCP_DMAPOOL_MAX_SIZE);
> } else {
> wa->address = kzalloc(len, GFP_KERNEL);
> if (!wa->address)
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] crypto: ccp - Replace dma_pool_alloc + memset with dma_pool_zalloc
2019-07-18 13:16 [PATCH] crypto: ccp - Replace dma_pool_alloc + memset with dma_pool_zalloc Chuhong Yuan
2019-07-18 21:50 ` Gary R Hook
@ 2019-07-26 12:35 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2019-07-26 12:35 UTC (permalink / raw)
To: Chuhong Yuan
Chuhong Yuan <hslester96@gmail.com> wrote:
> Use dma_pool_zalloc instead of using dma_pool_alloc to allocate
> memory and then zeroing it with memset 0.
> This simplifies the code.
>
> Signed-off-by: Chuhong Yuan <hslester96@gmail.com>
> ---
> drivers/crypto/ccp/ccp-ops.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Patch applied. Thanks.
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-26 12:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18 13:16 [PATCH] crypto: ccp - Replace dma_pool_alloc + memset with dma_pool_zalloc Chuhong Yuan
2019-07-18 21:50 ` Gary R Hook
2019-07-26 12:35 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®