* [PATCH] scsi: pmcraid: Use dma_pool_zalloc rather than dma_pool_alloc
@ 2019-07-18 18:10 Vasyl Gomonovych
2019-07-18 18:37 ` Joe Perches
0 siblings, 1 reply; 3+ messages in thread
From: Vasyl Gomonovych @ 2019-07-18 18:10 UTC (permalink / raw)
To: gomonovych
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, linux-kernel
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0
The semantic patch that makes this change is available
in scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci.
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/scsi/pmcraid.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 71ff3936da4f945f3d8a798a8b2129ca3c07ec22..f79d7750934e629c6d6edc1a075205247889531d 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4653,9 +4653,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
return -ENOMEM;
for (i = 0; i < PMCRAID_MAX_CMD; i++) {
- pinstance->cmd_list[i]->ioa_cb =
- dma_pool_alloc(
- pinstance->control_pool,
+ pinstance->cmd_list[i]->ioa_cb = dma_pool_zalloc(pinstance->control_pool,
GFP_KERNEL,
&(pinstance->cmd_list[i]->ioa_cb_bus_addr));
@@ -4663,8 +4661,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
pmcraid_release_control_blocks(pinstance, i);
return -ENOMEM;
}
- memset(pinstance->cmd_list[i]->ioa_cb, 0,
- sizeof(struct pmcraid_control_block));
}
return 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: pmcraid: Use dma_pool_zalloc rather than dma_pool_alloc
2019-07-18 18:10 [PATCH] scsi: pmcraid: Use dma_pool_zalloc rather than dma_pool_alloc Vasyl Gomonovych
@ 2019-07-18 18:37 ` Joe Perches
0 siblings, 0 replies; 3+ messages in thread
From: Joe Perches @ 2019-07-18 18:37 UTC (permalink / raw)
To: Vasyl Gomonovych
Cc: James E.J. Bottomley, Martin K. Petersen, linux-scsi, linux-kernel
On Thu, 2019-07-18 at 20:10 +0200, Vasyl Gomonovych wrote:
> Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0
> The semantic patch that makes this change is available
> in scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci.
[]
> diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
[]
> @@ -4653,9 +4653,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
> return -ENOMEM;
>
> for (i = 0; i < PMCRAID_MAX_CMD; i++) {
> - pinstance->cmd_list[i]->ioa_cb =
> - dma_pool_alloc(
> - pinstance->control_pool,
> + pinstance->cmd_list[i]->ioa_cb = dma_pool_zalloc(pinstance->control_pool,
> GFP_KERNEL,
> &(pinstance->cmd_list[i]->ioa_cb_bus_addr));
>
> @@ -4663,8 +4661,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
> pmcraid_release_control_blocks(pinstance, i);
> return -ENOMEM;
> }
> - memset(pinstance->cmd_list[i]->ioa_cb, 0,
> - sizeof(struct pmcraid_control_block));
> }
> return 0;
> }
While this change is somewhat overdone as only
dma_pool_alloc could be changed to dma_pool_zalloc
on the same line without rewrapping other arguments,
I'd generally write this with a temporary like:
---
drivers/scsi/pmcraid.c | 14 ++++++--------
1 file changed, 6 insertions(+), 8 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 71ff3936da4f..88e7b18ad44d 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4653,19 +4653,17 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
return -ENOMEM;
for (i = 0; i < PMCRAID_MAX_CMD; i++) {
- pinstance->cmd_list[i]->ioa_cb =
- dma_pool_alloc(
- pinstance->control_pool,
- GFP_KERNEL,
- &(pinstance->cmd_list[i]->ioa_cb_bus_addr));
+ struct pmcraid_cmd *cmd = pinstance->cmd_list[i];
- if (!pinstance->cmd_list[i]->ioa_cb) {
+ cmd->ioa_cb = dma_pool_zalloc(pinstance->control_pool,
+ GFP_KERNEL,
+ &cmd->ioa_cb_bus_addr);
+ if (!cmd->ioa_cb) {
pmcraid_release_control_blocks(pinstance, i);
return -ENOMEM;
}
- memset(pinstance->cmd_list[i]->ioa_cb, 0,
- sizeof(struct pmcraid_control_block));
}
+
return 0;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] scsi: pmcraid: Use dma_pool_zalloc rather than dma_pool_alloc
@ 2019-07-18 18:11 Vasyl Gomonovych
0 siblings, 0 replies; 3+ messages in thread
From: Vasyl Gomonovych @ 2019-07-18 18:11 UTC (permalink / raw)
To: jejb, martin.petersen, linux-scsi; +Cc: Vasyl Gomonovych, linux-kernel
Use *_pool_zalloc rather than *_pool_alloc followed by memset with 0
The semantic patch that makes this change is available
in scripts/coccinelle/api/alloc/pool_zalloc-simple.cocci.
Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com>
---
drivers/scsi/pmcraid.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/scsi/pmcraid.c b/drivers/scsi/pmcraid.c
index 71ff3936da4f945f3d8a798a8b2129ca3c07ec22..f79d7750934e629c6d6edc1a075205247889531d 100644
--- a/drivers/scsi/pmcraid.c
+++ b/drivers/scsi/pmcraid.c
@@ -4653,9 +4653,7 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
return -ENOMEM;
for (i = 0; i < PMCRAID_MAX_CMD; i++) {
- pinstance->cmd_list[i]->ioa_cb =
- dma_pool_alloc(
- pinstance->control_pool,
+ pinstance->cmd_list[i]->ioa_cb = dma_pool_zalloc(pinstance->control_pool,
GFP_KERNEL,
&(pinstance->cmd_list[i]->ioa_cb_bus_addr));
@@ -4663,8 +4661,6 @@ static int pmcraid_allocate_control_blocks(struct pmcraid_instance *pinstance)
pmcraid_release_control_blocks(pinstance, i);
return -ENOMEM;
}
- memset(pinstance->cmd_list[i]->ioa_cb, 0,
- sizeof(struct pmcraid_control_block));
}
return 0;
}
--
2.17.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-18 18:37 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-18 18:10 [PATCH] scsi: pmcraid: Use dma_pool_zalloc rather than dma_pool_alloc Vasyl Gomonovych
2019-07-18 18:37 ` Joe Perches
2019-07-18 18:11 Vasyl Gomonovych
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®