mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: john.hubbard@gmail.com
To: pavel@ucw.cz
Cc: SCheung@nvidia.com, akpm@linux-foundation.org,
	aneesh.kumar@linux.vnet.ibm.com, benh@kernel.crashing.org,
	bsingharora@gmail.com, dan.j.williams@intel.com,
	dnellans@nvidia.com, ebaskakov@nvidia.com, hannes@cmpxchg.org,
	jglisse@redhat.com, jhubbard@nvidia.com,
	kirill.shutemov@linux.intel.com, linux-kernel@vger.kernel.org,
	liubo95@huawei.com, mhairgrove@nvidia.com, mhocko@kernel.org,
	paulmck@linux.vnet.ibm.com, ross.zwisler@linux.intel.com,
	sgutti@nvidia.com, torvalds@linux-foundation.org,
	vdavydov.dev@gmail.com, Jason Gunthorpe <jgg@ziepe.ca>,
	Christoph Hellwig <hch@infradead.org>
Subject: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option
Date: Thu, 18 Jul 2019 18:32:53 -0700	[thread overview]
Message-ID: <20190719013253.17642-1-jhubbard@nvidia.com> (raw)
In-Reply-To: <20190717074124.GA21617@amd>

From: John Hubbard <jhubbard@nvidia.com>

The HMM_MIRROR option in Kconfig is a little underdocumented and
mysterious, and leaves people wondering whether to enable it.

Add text explaining just a little bit more about HMM, and also
mention which hardware would benefit from having HMM_MIRROR
enabled.

Suggested-by: Pavel Machek <pavel@ucw.cz>
Cc: Balbir Singh <bsingharora@gmail.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Jason Gunthorpe <jgg@ziepe.ca>
Cc: Jerome Glisse <jglisse@redhat.com>
Cc: Christoph Hellwig <hch@infradead.org>
Signed-off-by: John Hubbard <jhubbard@nvidia.com>
---

Hi Pavel and all, does this help? I've tried to capture the key missing bits
of documentation, but still keep it small, for Kconfig.

thanks,
John Hubbard
NVIDIA

 mm/Kconfig | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/mm/Kconfig b/mm/Kconfig
index 56cec636a1fc..2fcb92e7f696 100644
--- a/mm/Kconfig
+++ b/mm/Kconfig
@@ -681,11 +681,18 @@ config HMM_MIRROR
 	depends on MMU && 64BIT
 	select MMU_NOTIFIER
 	help
-	  Select HMM_MIRROR if you want to mirror range of the CPU page table of a
-	  process into a device page table. Here, mirror means "keep synchronized".
-	  Prerequisites: the device must provide the ability to write-protect its
-	  page tables (at PAGE_SIZE granularity), and must be able to recover from
-	  the resulting potential page faults.
+	  This is Heterogeneous Memory Management (HMM) process address space
+	  mirroring.
+
+	  HMM_MIRROR provides a way to mirror ranges of the CPU page tables
+	  of a process into a device page table. Here, mirror means "keep
+	  synchronized". Prerequisites: the device must provide the ability
+	  to write-protect its page tables (at PAGE_SIZE granularity), and
+	  must be able to recover from the resulting potential page faults.
+
+	  Select HMM_MIRROR if you have hardware that meets the above
+	  description. An early, partial list of such hardware is:
+	  an NVIDIA GPU >= Pascal, Mellanox IB >= mlx5, or an AMD GPU.
 
 config DEVICE_PRIVATE
 	bool "Unaddressable device memory (GPU memory, ...)"
-- 
2.22.0


  parent reply	other threads:[~2019-07-19  1:33 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-17  7:41 HMM_MIRROR has less than useful help text Pavel Machek
2019-07-18 11:03 ` Balbir Singh
2019-07-18 14:25   ` Dan Williams
2019-07-18 16:36     ` Pavel Machek
2019-07-19  1:32 ` john.hubbard [this message]
2019-07-19  4:34   ` [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option Ira Weiny
2019-07-19  5:15     ` John Hubbard
2019-07-19  5:57   ` Christoph Hellwig
2019-07-19 10:52     ` Pavel Machek
2019-07-19 11:48       ` Jason Gunthorpe
2019-07-19 12:00         ` Christoph Hellwig
2019-07-19 12:04           ` Pavel Machek
2019-07-19 20:38             ` John Hubbard
2019-07-22 11:58               ` Jason Gunthorpe
2019-07-22 12:01                 ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190719013253.17642-1-jhubbard@nvidia.com \
    --to=john.hubbard@gmail.com \
    --cc=SCheung@nvidia.com \
    --cc=akpm@linux-foundation.org \
    --cc=aneesh.kumar@linux.vnet.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=bsingharora@gmail.com \
    --cc=dan.j.williams@intel.com \
    --cc=dnellans@nvidia.com \
    --cc=ebaskakov@nvidia.com \
    --cc=hannes@cmpxchg.org \
    --cc=hch@infradead.org \
    --cc=jgg@ziepe.ca \
    --cc=jglisse@redhat.com \
    --cc=jhubbard@nvidia.com \
    --cc=kirill.shutemov@linux.intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=liubo95@huawei.com \
    --cc=mhairgrove@nvidia.com \
    --cc=mhocko@kernel.org \
    --cc=paulmck@linux.vnet.ibm.com \
    --cc=pavel@ucw.cz \
    --cc=ross.zwisler@linux.intel.com \
    --cc=sgutti@nvidia.com \
    --cc=torvalds@linux-foundation.org \
    --cc=vdavydov.dev@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®