From: Jason Gunthorpe <jgg@ziepe.ca>
To: Pavel Machek <pavel@ucw.cz>
Cc: Christoph Hellwig <hch@infradead.org>,
john.hubbard@gmail.com, SCheung@nvidia.com,
akpm@linux-foundation.org, aneesh.kumar@linux.vnet.ibm.com,
benh@kernel.crashing.org, bsingharora@gmail.com,
dan.j.williams@intel.com, dnellans@nvidia.com,
ebaskakov@nvidia.com, hannes@cmpxchg.org, jglisse@redhat.com,
jhubbard@nvidia.com, kirill.shutemov@linux.intel.com,
linux-kernel@vger.kernel.org, liubo95@huawei.com,
mhairgrove@nvidia.com, mhocko@kernel.org,
paulmck@linux.vnet.ibm.com, ross.zwisler@linux.intel.com,
sgutti@nvidia.com, torvalds@linux-foundation.org,
vdavydov.dev@gmail.com
Subject: Re: [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option
Date: Fri, 19 Jul 2019 08:48:53 -0300 [thread overview]
Message-ID: <20190719114853.GB15816@ziepe.ca> (raw)
In-Reply-To: <20190719105239.GA10627@amd>
On Fri, Jul 19, 2019 at 12:52:39PM +0200, Pavel Machek wrote:
> On Thu 2019-07-18 22:57:48, Christoph Hellwig wrote:
> > On Thu, Jul 18, 2019 at 06:32:53PM -0700, john.hubbard@gmail.com wrote:
> > > + HMM_MIRROR provides a way to mirror ranges of the CPU page tables
> > > + of a process into a device page table. Here, mirror means "keep
> > > + synchronized". Prerequisites: the device must provide the ability
> > > + to write-protect its page tables (at PAGE_SIZE granularity), and
> > > + must be able to recover from the resulting potential page faults.
> > > +
> > > + Select HMM_MIRROR if you have hardware that meets the above
> > > + description. An early, partial list of such hardware is:
> > > + an NVIDIA GPU >= Pascal, Mellanox IB >= mlx5, or an AMD GPU.
> >
> > Nevermind that the Nvidia support is stagaging and looks rather broken,
> > there is no Mellanox user of this either at this point.
> >
> > But either way this has no business in a common kconfig help. Just
> > drop the fine grained details and leave it to the overview.
>
> I disagree here. This explains what kind of hardware this is for (very
> new). Partial list does not hurt, and I know that I probably don't
> need to enable this.
>
> How else am I supposed to know if my computer needs page tables
> synchronized?
It is like MMU_NOTIFIERS, if something needs it, then it will select
it.
Maybe it should just be a hidden kconfig anyhow as there is no reason
to turn it on without also turning on a using driver.
Jason
next prev parent reply other threads:[~2019-07-19 11:48 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 7:41 HMM_MIRROR has less than useful help text Pavel Machek
2019-07-18 11:03 ` Balbir Singh
2019-07-18 14:25 ` Dan Williams
2019-07-18 16:36 ` Pavel Machek
2019-07-19 1:32 ` [PATCH] mm/Kconfig: additional help text for HMM_MIRROR option john.hubbard
2019-07-19 4:34 ` Ira Weiny
2019-07-19 5:15 ` John Hubbard
2019-07-19 5:57 ` Christoph Hellwig
2019-07-19 10:52 ` Pavel Machek
2019-07-19 11:48 ` Jason Gunthorpe [this message]
2019-07-19 12:00 ` Christoph Hellwig
2019-07-19 12:04 ` Pavel Machek
2019-07-19 20:38 ` John Hubbard
2019-07-22 11:58 ` Jason Gunthorpe
2019-07-22 12:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190719114853.GB15816@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=SCheung@nvidia.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.vnet.ibm.com \
--cc=benh@kernel.crashing.org \
--cc=bsingharora@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=dnellans@nvidia.com \
--cc=ebaskakov@nvidia.com \
--cc=hannes@cmpxchg.org \
--cc=hch@infradead.org \
--cc=jglisse@redhat.com \
--cc=jhubbard@nvidia.com \
--cc=john.hubbard@gmail.com \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liubo95@huawei.com \
--cc=mhairgrove@nvidia.com \
--cc=mhocko@kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=pavel@ucw.cz \
--cc=ross.zwisler@linux.intel.com \
--cc=sgutti@nvidia.com \
--cc=torvalds@linux-foundation.org \
--cc=vdavydov.dev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®