* [PATCH] extcon: sm5502: Add IRQ_ONESHOT @ 2019-07-19 16:28 ` Vasyl Gomonovych 2019-07-24 10:34 ` Chanwoo Choi 0 siblings, 1 reply; 2+ messages in thread From: Vasyl Gomonovych @ 2019-07-19 16:28 UTC (permalink / raw) To: myungjoo.ham, cw00.choi; +Cc: Vasyl Gomonovych, linux-kernel Do not fire irq again until thread done Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com> --- Can you please look on this from false positives point of view --- drivers/extcon/extcon-sm5502.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c index 98e4f616b8f1..dc43847ad2b0 100644 --- a/drivers/extcon/extcon-sm5502.c +++ b/drivers/extcon/extcon-sm5502.c @@ -597,7 +597,7 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c, ret = devm_request_threaded_irq(info->dev, virq, NULL, sm5502_muic_irq_handler, - IRQF_NO_SUSPEND, + IRQF_NO_SUSPEND | IRQF_ONESHOT, muic_irq->name, info); if (ret) { dev_err(info->dev, -- 2.17.1 ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] extcon: sm5502: Add IRQ_ONESHOT 2019-07-19 16:28 ` [PATCH] extcon: sm5502: Add IRQ_ONESHOT Vasyl Gomonovych @ 2019-07-24 10:34 ` Chanwoo Choi 0 siblings, 0 replies; 2+ messages in thread From: Chanwoo Choi @ 2019-07-24 10:34 UTC (permalink / raw) To: Vasyl Gomonovych, myungjoo.ham; +Cc: linux-kernel On 19. 7. 20. 오전 1:28, Vasyl Gomonovych wrote: > Do not fire irq again until thread done > > Signed-off-by: Vasyl Gomonovych <gomonovych@gmail.com> > --- > Can you please look on this from false positives point of view > --- > drivers/extcon/extcon-sm5502.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/extcon/extcon-sm5502.c b/drivers/extcon/extcon-sm5502.c > index 98e4f616b8f1..dc43847ad2b0 100644 > --- a/drivers/extcon/extcon-sm5502.c > +++ b/drivers/extcon/extcon-sm5502.c > @@ -597,7 +597,7 @@ static int sm5022_muic_i2c_probe(struct i2c_client *i2c, > > ret = devm_request_threaded_irq(info->dev, virq, NULL, > sm5502_muic_irq_handler, > - IRQF_NO_SUSPEND, > + IRQF_NO_SUSPEND | IRQF_ONESHOT, > muic_irq->name, info); > if (ret) { > dev_err(info->dev, > Applied it. Thanks. -- Best Regards, Chanwoo Choi Samsung Electronics ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-07-24 10:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190719162821epcas3p17fcf008cf87a010463aad86fbcf4f7e3@epcas3p1.samsung.com>
2019-07-19 16:28 ` [PATCH] extcon: sm5502: Add IRQ_ONESHOT Vasyl Gomonovych
2019-07-24 10:34 ` Chanwoo Choi
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®