Re: [PATCH v9 4/4] uprobe: use FOLL_SPLIT_PMD instead of FOLL_SPLIT

Re: [PATCH v9 4/4] uprobe: use FOLL_SPLIT_PMD instead of FOLL_SPLIT

[Andrew Morton]

On Thu, 25 Jul 2019 22:46:54 -0700 Song Liu <songliubraving@fb.com> wrote:

> This patches uses newly added FOLL_SPLIT_PMD in uprobe. This enables easy
> regroup of huge pmd after the uprobe is disabled (in next patch).

Confused.  There is no "next patch".

Re: [PATCH v9 4/4] uprobe: use FOLL_SPLIT_PMD instead of FOLL_SPLIT

[Song Liu]

> On Jul 26, 2019, at 4:02 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> On Thu, 25 Jul 2019 22:46:54 -0700 Song Liu <songliubraving@fb.com> wrote:
> 
>> This patches uses newly added FOLL_SPLIT_PMD in uprobe. This enables easy
>> regroup of huge pmd after the uprobe is disabled (in next patch).
> 
> Confused.  There is no "next patch".

That was the patch 5, which was in earlier versions. I am working on 
addressing Kirill's feedback for it. 

Do I need to resubmit 4/4 with modified change log? 

Thanks,
Song

Re: [PATCH v9 4/4] uprobe: use FOLL_SPLIT_PMD instead of FOLL_SPLIT

[Andrew Morton]

On Fri, 26 Jul 2019 23:44:34 +0000 Song Liu <songliubraving@fb.com> wrote:

> 
> 
> > On Jul 26, 2019, at 4:02 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> > 
> > On Thu, 25 Jul 2019 22:46:54 -0700 Song Liu <songliubraving@fb.com> wrote:
> > 
> >> This patches uses newly added FOLL_SPLIT_PMD in uprobe. This enables easy
> >> regroup of huge pmd after the uprobe is disabled (in next patch).
> > 
> > Confused.  There is no "next patch".
> 
> That was the patch 5, which was in earlier versions. I am working on 
> addressing Kirill's feedback for it. 
> 
> Do I need to resubmit 4/4 with modified change log? 

Please just send new changelog text now.  I assume this [4/4] patch is
useful without patch #5, but a description of why it is useful is
appropriate.

I trust the fifth patch is to be sent soon?

Re: [PATCH v9 4/4] uprobe: use FOLL_SPLIT_PMD instead of FOLL_SPLIT

[Song Liu]

> On Jul 26, 2019, at 4:52 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
> 
> On Fri, 26 Jul 2019 23:44:34 +0000 Song Liu <songliubraving@fb.com> wrote:
> 
>> 
>> 
>>> On Jul 26, 2019, at 4:02 PM, Andrew Morton <akpm@linux-foundation.org> wrote:
>>> 
>>> On Thu, 25 Jul 2019 22:46:54 -0700 Song Liu <songliubraving@fb.com> wrote:
>>> 
>>>> This patches uses newly added FOLL_SPLIT_PMD in uprobe. This enables easy
>>>> regroup of huge pmd after the uprobe is disabled (in next patch).
>>> 
>>> Confused.  There is no "next patch".
>> 
>> That was the patch 5, which was in earlier versions. I am working on 
>> addressing Kirill's feedback for it. 
>> 
>> Do I need to resubmit 4/4 with modified change log? 
> 
> Please just send new changelog text now.  I assume this [4/4] patch is
> useful without patch #5, but a description of why it is useful is
> appropriate.

Yes, 4/4 is useful with #5. Please find the updated change log. 

============= 8< ====================

This patch uses newly added FOLL_SPLIT_PMD in uprobe. This preserves the 
huge page when the uprobe is enabled. When the uprobe is disabled, newer 
instances of the same application could still benefit from huge page. 

For the next step, we will enable khugepaged to regroup the pmd, so that 
existing instances of the application could also benefit from huge page 
after the uprobe is disabled. 

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Reviewed-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
Signed-off-by: Song Liu <songliubraving@fb.com>

============= 8< ====================

> 
> I trust the fifth patch is to be sent soon?

Yes, I am working on it. 

Thanks,
Song