* [PATCH] kmemleak: Increase DEBUG_KMEMLEAK_EARLY_LOG_SIZE default to 16K
@ 2019-07-30 15:40 Nicolas Boichat
2019-07-30 15:42 ` Catalin Marinas
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Boichat @ 2019-07-30 15:40 UTC (permalink / raw)
To: Andrew Morton
Cc: Masahiro Yamada, Kees Cook, Petr Mladek, Thomas Gleixner,
Tetsuo Handa, Joe Lawrence, Uladzislau Rezki, Andy Shevchenko,
linux-kernel, Stephen Rothwell, Catalin Marinas, Dmitry Vyukov,
Andrey Ryabinin
The current default value (400) is too low on many systems (e.g.
some ARM64 platform takes up 1000+ entries).
syzbot uses 16000 as default value, and has proved to be enough
on beefy configurations, so let's pick that value.
This consumes more RAM on boot (each entry is 160 bytes, so
in total ~2.5MB of RAM), but the memory would later be freed
(early_log is __initdata).
Suggested-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
---
lib/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index f567875b87657de..b5a24045ab13310 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -596,7 +596,7 @@ config DEBUG_KMEMLEAK_EARLY_LOG_SIZE
int "Maximum kmemleak early log entries"
depends on DEBUG_KMEMLEAK
range 200 40000
- default 400
+ default 16000
help
Kmemleak must track all the memory allocations to avoid
reporting false positives. Since memory may be allocated or
--
2.22.0.709.g102302147b-goog
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kmemleak: Increase DEBUG_KMEMLEAK_EARLY_LOG_SIZE default to 16K
2019-07-30 15:40 [PATCH] kmemleak: Increase DEBUG_KMEMLEAK_EARLY_LOG_SIZE default to 16K Nicolas Boichat
@ 2019-07-30 15:42 ` Catalin Marinas
2019-07-30 16:23 ` Dmitry Vyukov
0 siblings, 1 reply; 3+ messages in thread
From: Catalin Marinas @ 2019-07-30 15:42 UTC (permalink / raw)
To: Nicolas Boichat
Cc: Andrew Morton, Masahiro Yamada, Kees Cook, Petr Mladek,
Thomas Gleixner, Tetsuo Handa, Joe Lawrence, Uladzislau Rezki,
Andy Shevchenko, linux-kernel, Stephen Rothwell, Dmitry Vyukov,
Andrey Ryabinin
On Tue, Jul 30, 2019 at 11:40:27PM +0800, Nicolas Boichat wrote:
> The current default value (400) is too low on many systems (e.g.
> some ARM64 platform takes up 1000+ entries).
>
> syzbot uses 16000 as default value, and has proved to be enough
> on beefy configurations, so let's pick that value.
>
> This consumes more RAM on boot (each entry is 160 bytes, so
> in total ~2.5MB of RAM), but the memory would later be freed
> (early_log is __initdata).
>
> Suggested-by: Dmitry Vyukov <dvyukov@google.com>
> Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
Acked-by: Catalin Marinas <catalin.marinas@arm.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] kmemleak: Increase DEBUG_KMEMLEAK_EARLY_LOG_SIZE default to 16K
2019-07-30 15:42 ` Catalin Marinas
@ 2019-07-30 16:23 ` Dmitry Vyukov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Vyukov @ 2019-07-30 16:23 UTC (permalink / raw)
To: Catalin Marinas
Cc: Nicolas Boichat, Andrew Morton, Masahiro Yamada, Kees Cook,
Petr Mladek, Thomas Gleixner, Tetsuo Handa, Joe Lawrence,
Uladzislau Rezki, Andy Shevchenko, LKML, Stephen Rothwell,
Andrey Ryabinin
On Tue, Jul 30, 2019 at 5:42 PM Catalin Marinas <catalin.marinas@arm.com> wrote:
>
> On Tue, Jul 30, 2019 at 11:40:27PM +0800, Nicolas Boichat wrote:
> > The current default value (400) is too low on many systems (e.g.
> > some ARM64 platform takes up 1000+ entries).
> >
> > syzbot uses 16000 as default value, and has proved to be enough
> > on beefy configurations, so let's pick that value.
> >
> > This consumes more RAM on boot (each entry is 160 bytes, so
> > in total ~2.5MB of RAM), but the memory would later be freed
> > (early_log is __initdata).
> >
> > Suggested-by: Dmitry Vyukov <dvyukov@google.com>
> > Signed-off-by: Nicolas Boichat <drinkcat@chromium.org>
>
> Acked-by: Catalin Marinas <catalin.marinas@arm.com>
Acked-by: Dmitry Vyukov <dvyukov@google.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-30 16:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-30 15:40 [PATCH] kmemleak: Increase DEBUG_KMEMLEAK_EARLY_LOG_SIZE default to 16K Nicolas Boichat
2019-07-30 15:42 ` Catalin Marinas
2019-07-30 16:23 ` Dmitry Vyukov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®